-
Notifications
You must be signed in to change notification settings - Fork 0
add more quantity conversions #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov ReportBase: 67.15% // Head: 67.31% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #323 +/- ##
============================================
+ Coverage 67.15% 67.31% +0.15%
Complexity 231 231
============================================
Files 40 40
Lines 1236 1242 +6
Branches 117 117
============================================
+ Hits 830 836 +6
Misses 373 373
Partials 33 33
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I'd still link issue #322 in the same line as the other issue within the changelog
This comment has been minimized.
This comment has been minimized.
Analysis Details0 IssuesCoverage and DuplicationsProject ID: edu.ie3:utils |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks
Resolves #322
P.S.: Did not add a changeling entry as
- Enhanced RichQuantityDouble with new units and generic method [#312](https://github.com/ie3-institute/PowerSystemUtils/issues/312)
already covers this