Skip to content

add more quantity conversions #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 10, 2022
Merged

Conversation

t-ober
Copy link
Contributor

@t-ober t-ober commented Nov 9, 2022

Resolves #322

P.S.: Did not add a changeling entry as - Enhanced RichQuantityDouble with new units and generic method [#312](https://github.com/ie3-institute/PowerSystemUtils/issues/312) already covers this

@sonarqubegithubprchecks

This comment has been minimized.

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Base: 67.15% // Head: 67.31% // Increases project coverage by +0.15% 🎉

Coverage data is based on head (ced296e) compared to base (d0bfd17).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #323      +/-   ##
============================================
+ Coverage     67.15%   67.31%   +0.15%     
  Complexity      231      231              
============================================
  Files            40       40              
  Lines          1236     1242       +6     
  Branches        117      117              
============================================
+ Hits            830      836       +6     
  Misses          373      373              
  Partials         33       33              
Impacted Files Coverage Δ
.../scala/edu/ie3/util/quantities/QuantityUtils.scala 98.85% <0.00%> (+0.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I'd still link issue #322 in the same line as the other issue within the changelog

@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 100.00% Coverage (65.70% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: edu.ie3:utils

View in SonarQube

Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@sebastian-peter sebastian-peter merged commit b2f4b03 into main Nov 10, 2022
@sebastian-peter sebastian-peter deleted the to/#322-extend-quantity-utils branch November 10, 2022 18:05
@sebastian-peter sebastian-peter added this to the Version 2.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add some missing units of the our standard units to the quantity utils
2 participants