Skip to content

Remove unused fields from TimeUtil #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 21, 2024
Merged

Remove unused fields from TimeUtil #443

merged 4 commits into from
Feb 21, 2024

Conversation

danielfeismann
Copy link
Member

resolves #442

@danielfeismann danielfeismann added the enhancement New feature or request label Feb 13, 2024
@danielfeismann danielfeismann added this to the Version 2.1 milestone Feb 13, 2024
@danielfeismann danielfeismann self-assigned this Feb 13, 2024
@danielfeismann danielfeismann requested review from t-ober and removed request for t-ober February 13, 2024 15:34
@sonarqubegithubprchecks SonarQubeGithubPRChecks

This comment has been minimized.

Sign in to view
@danielfeismann danielfeismann marked this pull request as ready for review February 13, 2024 15:53
t-ober
t-ober requested changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@t-ober t-ober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor thing otherwise I think the simplification definitely makes sense.

@sonarqubegithubprchecks SonarQubeGithubPRChecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks SonarQubeGithubPRChecks
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 100.00% Coverage (65.80% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: edu.ie3:utils

View in SonarQube

@t-ober t-ober merged commit 502ee7d into main Feb 21, 2024
@t-ober t-ober deleted the df/#442_remove_fields_timeUtils branch February 21, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-ober t-ober t-ober approved these changes

Assignees

@danielfeismann danielfeismann

Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 2.2
Development

Successfully merging this pull request may close these issues.

Remove unused fields from TimeUtil
3 participants
@danielfeismann @t-ober @sebastian-peter