Skip to content

Preparing v 1.4 release #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 11, 2020
Merged

Preparing v 1.4 release #52

merged 11 commits into from
Nov 11, 2020

Conversation

ckittl
Copy link
Member

@ckittl ckittl commented Nov 10, 2020

No description provided.

@ckittl ckittl added the release Describes a release task label Nov 10, 2020
@ckittl ckittl added this to the Version 1.4 milestone Nov 10, 2020
@ckittl ckittl requested a review from a team November 10, 2020 08:14
@ckittl ckittl self-assigned this Nov 10, 2020
@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #52 (84a5475) into master (98f19ca) will increase coverage by 1.57%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #52      +/-   ##
============================================
+ Coverage     28.27%   29.84%   +1.57%     
  Complexity      119      119              
============================================
  Files            28       26       -2     
  Lines          1093     1022      -71     
  Branches        146      132      -14     
============================================
- Hits            309      305       -4     
+ Misses          777      710      -67     
  Partials          7        7              
Impacted Files Coverage Δ Complexity Δ
...ils/src/main/java/edu/ie3/util/io/FileIOUtils.java 26.78% <0.00%> (-2.07%) 3.00% <0.00%> (ø%)
...utils/src/main/java/edu/ie3/util/geo/GeoUtils.java 8.31% <0.00%> (-0.98%) 6.00% <0.00%> (ø%)
...mutils/src/main/java/edu/ie3/util/ArrayHelper.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...tils/src/main/java/edu/ie3/util/copy/DeepCopy.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...ils/src/main/java/edu/ie3/util/geo/GrahamScan.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...va/edu/ie3/util/copy/FastByteArrayInputStream.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...a/edu/ie3/util/copy/FastByteArrayOutputStream.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...temutils/src/main/java/edu/ie3/util/TimeTools.java
...main/java/edu/ie3/util/io/config/ConfigReader.java

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98f19ca...84a5475. Read the comment docs.

Copy link
Member

@johanneshiry johanneshiry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work especially considering the removals of code smells. However, I'm not happy with the removals @ GeoUtils and some other classes. Pls see me comments on this and consider further discussion.

@ckittl ckittl requested a review from johanneshiry November 11, 2020 08:25
@johanneshiry johanneshiry merged commit 6dd93ef into master Nov 11, 2020
@johanneshiry johanneshiry deleted the ck/v1.4-release branch November 11, 2020 15:14
ckittl added a commit that referenced this pull request Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Describes a release task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants