-
Notifications
You must be signed in to change notification settings - Fork 0
Implementation of GitHub Actions #541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 11 changed files in this pull request and generated no comments.
Files not reviewed (7)
- gradle/scripts/branchName.gradle: Language not supported
- gradle/scripts/semVer.gradle: Language not supported
- scripts/branch_type.sh: Language not supported
- scripts/get_versions.sh: Language not supported
- scripts/run-version-check.sh: Language not supported
- scripts/version_check.sh: Language not supported
- version.properties: Language not supported
Comments suppressed due to low confidence (2)
.github/workflows/dependabot-auto-merge.yml:21
- Ensure the GitHub CLI ('gh') is available in the runner environment. Without it, the auto-merge step may fail; alternatively, consider using an existing GitHub Action to merge pull requests.
run: gh pr merge --auto --merge "$PR_URL"
.github/workflows/ci.yml:90
- [nitpick] For consistency with earlier steps that extract the branch name into BRANCH_NAME, consider revisiting the deployment condition to use a unified variable reference.
if: github.ref == 'refs/heads/main' || github.ref == 'refs/heads/dev'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 11 changed files in this pull request and generated no comments.
Files not reviewed (7)
- gradle/scripts/branchName.gradle: Language not supported
- gradle/scripts/semVer.gradle: Language not supported
- scripts/branch_type.sh: Language not supported
- scripts/get_versions.sh: Language not supported
- scripts/run-version-check.sh: Language not supported
- scripts/version_check.sh: Language not supported
- version.properties: Language not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PhilippSchmelter Similar feedback to ie3-institute/MobilitySimulator#352 (review):
I think if we get semver in first, this should work :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, let's give it a try also in here!
Closes #540
This pull request introduces a comprehensive CI/CD pipeline using GitHub Actions, implements semantic versioning, and adds automated branch name validation. The key changes are grouped into CI/CD pipeline setup, semantic versioning tasks, and branch name validation.
CI/CD Pipeline Setup:
.github/workflows/ci.yml
).github/workflows/dependabot-auto-merge.yml
)Semantic Versioning:
gradle/scripts/semVer.gradle
)scripts/get_versions.sh
,scripts/run-version-check.sh
,scripts/version_check.sh
) [1] [2] [3]version.properties
to include semantic versioning details. (version.properties
)Branch Name Validation:
gradle/scripts/branchName.gradle
)scripts/branch_type.sh
)Documentation:
CHANGELOG.md
to include the addition of the GitHub Actions pipeline. (CHANGELOG.md
)