Skip to content

Deleted Jenkinsfile and fixed Deployment #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 16, 2025

Conversation

PhilippSchmelter
Copy link
Contributor

Closes #546

This pull request includes several changes to the gradle/scripts/mavenCentralPublish.gradle file to improve the Maven publishing process. The key changes involve updating task definitions, modifying property checks, and refining POM details.

Updates to task definitions:

  • Changed the task definitions for sourcesJar and javadocJar to use tasks.register instead of the older task creation method.

Property checks and version handling:

  • Added a check for the deployVersion property and introduced versionString to handle snapshot and normal versions differently.

POM details and artifact handling:

  • Updated the POM description and license URL to reflect the new project details. [1] [2]
  • Changed the assignment of groupId, artifactId, and version to use the new versionString and updated artifact references to use tasks.named.

Signing and POM generation:

  • Added in-memory PGP key usage for signing and updated the POM file generation task to use the new layout.

@PhilippSchmelter PhilippSchmelter added the ci Related to continuous integration label Apr 15, 2025
@PhilippSchmelter PhilippSchmelter added this to the Version 3.0 milestone Apr 15, 2025
@PhilippSchmelter PhilippSchmelter self-assigned this Apr 15, 2025

This comment has been minimized.

Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove printVersion from build.gradle, as it's not used anymore.

Also, please test deployment once at least

Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (65.80% Estimated after merge)
  • Duplications No duplication information (0.00% Estimated after merge)

Project ID: edu.ie3:utils

View in SonarQube

Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks, let's give it a try

@sebastian-peter sebastian-peter merged commit b8c4717 into main Apr 16, 2025
2 checks passed
@sebastian-peter sebastian-peter deleted the ps/#546-fixDeploymentRmJenkins branch April 16, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Jenkins and Deployment fix
2 participants