Skip to content

Switch to scala 3 + java 17 #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
johanneshiry opened this issue Jan 3, 2022 · 5 comments · Fixed by #1105
Closed
2 tasks done

Switch to scala 3 + java 17 #53

johanneshiry opened this issue Jan 3, 2022 · 5 comments · Fixed by #1105
Assignees
@johanneshiry @staudtMarius
Labels
enhancement New feature or request

Comments

@johanneshiry
Copy link
Member

johanneshiry commented Jan 3, 2022 •
edited by staudtMarius
Loading

Scala 3 has several improvements over the currently used scala version. Even more, in the mid-term I expect that we will run into several problems if we stick to scala 2.

We may consider using this version change to also switch to the latest java LTS which is currently java 17.

For a full switch, we depend on updates of the following tools to support scala 3

We should also consider using this change for a new, actually the first public, release.
Therefore it might make sense to solve #17 before.
@johanneshiry johanneshiry added the enhancement New feature or request label Jan 3, 2022
@johanneshiry johanneshiry self-assigned this Jan 3, 2022
@johanneshiry johanneshiry changed the title Switch to scala 3 Switch to scala 3 + java 17 Jan 3, 2022
@johanneshiry johanneshiry mentioned this issue Jan 4, 2022
Open
This was referenced Jan 5, 2022
Closed
Closed
@sebastian-peter
Copy link
Member

JDK has been upgraded to version 17 now in #60

@TheElectronWill
Copy link

scoverage has been updated ✔️

@sebastian-peter
Copy link
Member

Now, gradle-scoverage supports scoverage 2 (and thus Scala 3) as well: scoverage/gradle-scoverage#192

@staudtMarius staudtMarius mentioned this issue Dec 4, 2023
Closed
staudtMarius added a commit that referenced this issue Dec 4, 2023
@staudtMarius
Merge branch 'dev' into ms/#53-switch-to-scala3
991977e
@t1b00
Copy link

t1b00 commented Oct 24, 2024

For the Scapegoat requirement, feel free to checkout my repo, I have been working on a port of Scapegoat to Scala 3 and currently have a working and tested version with 70 rules.
I hope this helps you switch your project to Scala 3 :)

@sebastian-peter
Copy link
Member

@t1b00 thanks for the hint, we'll consider your repo when we discuss a switch to Scala 3 again

@staudtMarius staudtMarius mentioned this issue Jan 14, 2025
Merged
staudtMarius added a commit that referenced this issue Jan 16, 2025
@staudtMarius
Merge branch 'dev' into ms/#53-upgrate-to-scala3
5094b8a 
# Conflicts:
#	build.gradle
#	gradle/scripts/scoverage.gradle
staudtMarius added a commit that referenced this issue Jan 28, 2025
@staudtMarius
Merge branch 'dev' into ms/#53-upgrate-to-scala3
34c4423 
# Conflicts:
#	src/main/scala/edu/ie3/simona/agent/grid/DBFSAlgorithm.scala
staudtMarius added a commit that referenced this issue Feb 18, 2025
@staudtMarius
Merge branch 'dev' into ms/#53-upgrate-to-scala3
ba6b67a 
# Conflicts:
#	CHANGELOG.md
#	src/main/scala/edu/ie3/simona/agent/participant/ParticipantAgent.scala
#	src/main/scala/edu/ie3/simona/agent/participant/ParticipantAgentFundamentals.scala
#	src/main/scala/edu/ie3/simona/agent/participant/ServiceRegistration.scala
#	src/main/scala/edu/ie3/simona/agent/participant/data/Data.scala
#	src/main/scala/edu/ie3/simona/agent/participant/statedata/BaseStateData.scala
#	src/main/scala/edu/ie3/simona/agent/participant/statedata/DataCollectionStateData.scala
#	src/main/scala/edu/ie3/simona/agent/participant/statedata/ParticipantStateData.scala
#	src/main/scala/edu/ie3/simona/io/result/AccompaniedSimulationResult.scala
#	src/main/scala/edu/ie3/simona/model/participant/SystemParticipant.scala
#	src/test/scala/edu/ie3/simona/agent/em/EmAgentIT.scala
#	src/test/scala/edu/ie3/simona/event/listener/RuntimeEventListenerKafkaSpec.scala
staudtMarius added a commit that referenced this issue Feb 18, 2025
@staudtMarius
Merge branch 'dev' into ms/#53-upgrate-to-scala3
3ff9069 
# Conflicts:
#	src/main/scala/edu/ie3/simona/agent/grid/ReceivedValuesStore.scala
staudtMarius added a commit that referenced this issue Feb 27, 2025
@staudtMarius
Merge branch 'dev' into ms/#53-upgrate-to-scala3
282edc4 
# Conflicts:
#	CHANGELOG.md
#	src/main/scala/edu/ie3/simona/config/ConfigFailFast.scala
#	src/main/scala/edu/ie3/simona/config/RuntimeConfig.scala
#	src/main/scala/edu/ie3/simona/config/SimonaConfig.scala
#	src/main/scala/edu/ie3/simona/event/listener/SimonaListenerCompanion.scala
#	src/main/scala/edu/ie3/simona/model/participant/WecModel.scala
#	src/main/scala/edu/ie3/util/scala/ReflectionTools.scala
#	src/test/scala/edu/ie3/simona/agent/participant/ParticipantAgentExternalSourceSpec.scala
staudtMarius added a commit that referenced this issue Mar 6, 2025
@staudtMarius
Merge branch 'dev' into ms/#53-upgrate-to-scala3
1e16137 
# Conflicts:
#	CHANGELOG.md
#	src/main/scala/edu/ie3/simona/config/ArgsParser.scala
#	src/main/scala/edu/ie3/simona/model/participant/HpModel.scala
#	src/main/scala/edu/ie3/simona/model/participant2/PrimaryDataParticipantModel.scala
#	src/main/scala/edu/ie3/simona/model/thermal/CylindricalThermalStorage.scala
staudtMarius added a commit that referenced this issue Mar 10, 2025
@staudtMarius
Merge branch 'dev' into ms/#53-upgrate-to-scala3
1e65455 
# Conflicts:
#	CHANGELOG.md
staudtMarius added a commit that referenced this issue Mar 18, 2025
@staudtMarius
Merge branch 'dev' into ms/#53-upgrate-to-scala3
2296cd3 
# Conflicts:
#	CHANGELOG.md
#	build.gradle
#	src/main/scala/edu/ie3/simona/config/ConfigFailFast.scala
#	src/main/scala/edu/ie3/simona/config/RuntimeConfig.scala
#	src/main/scala/edu/ie3/simona/config/SimonaConfig.scala
#	src/main/scala/edu/ie3/simona/io/runtime/RuntimeEventKafkaSink.scala
#	src/main/scala/edu/ie3/simona/model/participant/HpModel.scala
#	src/main/scala/edu/ie3/simona/model/participant2/ParticipantModelInit.scala
#	src/main/scala/edu/ie3/simona/model/participant2/ParticipantModelShell.scala
#	src/main/scala/edu/ie3/simona/model/thermal/CylindricalThermalStorage.scala
#	src/main/scala/edu/ie3/simona/model/thermal/MutableStorage.scala
#	src/main/scala/edu/ie3/simona/service/weather/WeatherSource.scala
#	src/main/scala/edu/ie3/simona/util/ConfigUtil.scala
#	src/test/scala/edu/ie3/simona/agent/em/EmAgentIT.scala
#	src/test/scala/edu/ie3/simona/model/participant/ChpModelSpec.scala
#	src/test/scala/edu/ie3/simona/model/thermal/CylindricalThermalStorageSpec.scala
staudtMarius added a commit that referenced this issue Mar 21, 2025
@staudtMarius
Merge branch 'dev' into ms/#53-upgrate-to-scala3
1c28c46 
# Conflicts:
#	CHANGELOG.md
#	build.gradle
#	src/main/scala/edu/ie3/simona/service/weather/WeatherService.scala
#	src/test/scala/edu/ie3/simona/service/weather/WeatherServiceSpec.scala
staudtMarius added a commit that referenced this issue Mar 24, 2025
@staudtMarius
Merge branch 'dev' into ms/#53-upgrate-to-scala3
e0f4772 
# Conflicts:
#	CHANGELOG.md
#	src/main/scala/edu/ie3/simona/service/primary/PrimaryServiceProxy.scala
#	src/test/scala/edu/ie3/simona/agent/grid/ThermalGridIT.scala
#	src/test/scala/edu/ie3/simona/service/primary/PrimaryServiceProxySpec.scala
staudtMarius added a commit that referenced this issue Apr 4, 2025
@staudtMarius
Merge branch 'dev' into ms/#53-upgrate-to-scala3
772eb65 
# Conflicts:
#	.scalafmt.conf
#	CHANGELOG.md
#	src/main/scala/edu/ie3/simona/config/SimonaConfig.scala
#	src/main/scala/edu/ie3/simona/main/RunSimonaStandalone.scala
#	src/main/scala/edu/ie3/simona/model/em/PrioritizedFlexStrat.scala
#	src/main/scala/edu/ie3/simona/model/participant2/ParticipantModelInit.scala
#	src/main/scala/edu/ie3/simona/model/participant2/ParticipantModelShell.scala
#	src/main/scala/edu/ie3/simona/ontology/messages/flex/MinMaxFlexibilityMessage.scala
#	src/main/scala/edu/ie3/simona/sim/setup/SetupHelper.scala
#	src/main/scala/edu/ie3/simona/util/ResultFileHierarchy.scala
#	src/test/scala/edu/ie3/simona/agent/grid/ThermalGridIT.scala
#	src/test/scala/edu/ie3/simona/integration/RunSimonaStandaloneIT.scala
staudtMarius added a commit that referenced this issue Apr 16, 2025
@staudtMarius
Merge branch 'dev' into ms/#53-upgrate-to-scala3
e1c255c 
# Conflicts:
#	CHANGELOG.md
#	src/main/scala/edu/ie3/simona/agent/participant/hp/HpAgentFundamentals.scala
#	src/main/scala/edu/ie3/simona/model/grid/TransformerModel.scala
#	src/test/scala/edu/ie3/simona/agent/grid/ThermalGridIT.scala
staudtMarius added a commit that referenced this issue Apr 25, 2025
@staudtMarius
Merge branch 'dev' into ms/#53-upgrate-to-scala3
9a4f4f0 
# Conflicts:
#	CHANGELOG.md
#	src/main/scala/edu/ie3/simona/agent/participant/ParticipantAgentFundamentals.scala
#	src/main/scala/edu/ie3/simona/agent/participant/statedata/BaseStateData.scala
#	src/main/scala/edu/ie3/simona/agent/participant/statedata/DataCollectionStateData.scala
#	src/main/scala/edu/ie3/simona/agent/participant/statedata/InitializeStateData.scala
#	src/main/scala/edu/ie3/simona/agent/participant/statedata/ParticipantStateData.scala
#	src/main/scala/edu/ie3/simona/agent/participant/statedata/UninitializedStateData.scala
#	src/main/scala/edu/ie3/simona/agent/participant2/ParticipantAgent.scala
#	src/main/scala/edu/ie3/simona/config/SimonaConfig.scala
#	src/main/scala/edu/ie3/simona/model/participant/BmModel.scala
#	src/main/scala/edu/ie3/simona/model/participant/FixedFeedInModel.scala
#	src/main/scala/edu/ie3/simona/model/participant/HpModel.scala
#	src/main/scala/edu/ie3/simona/model/participant/PvModel.scala
#	src/main/scala/edu/ie3/simona/model/participant/SystemParticipant.scala
#	src/main/scala/edu/ie3/simona/model/participant/evcs/EvcsModel.scala
#	src/main/scala/edu/ie3/simona/model/participant/load/LoadModel.scala
#	src/main/scala/edu/ie3/simona/sim/setup/ExtSimSetupData.scala
#	src/test/scala/edu/ie3/simona/agent/grid/ThermalGridIT.scala
#	src/test/scala/edu/ie3/simona/agent/participant/MockParticipantModel.scala
#	src/test/scala/edu/ie3/simona/agent/participant/ParticipantAgentMock.scala
staudtMarius added a commit that referenced this issue Apr 28, 2025
@staudtMarius
Merge branch 'dev' into ms/#53-upgrate-to-scala3
0d900d6
staudtMarius added a commit that referenced this issue May 6, 2025
@staudtMarius
Merge branch 'dev' into ms/#53-upgrate-to-scala3
92b408c 
# Conflicts:
#	build.gradle
#	src/main/scala/edu/ie3/simona/config/InputConfig.scala
#	src/main/scala/edu/ie3/simona/config/OutputConfig.scala
#	src/main/scala/edu/ie3/simona/config/RuntimeConfig.scala
staudtMarius added a commit that referenced this issue May 6, 2025
@staudtMarius
Merge branch 'dev' into ms/#53-upgrate-to-scala3
9852d0c 
# Conflicts:
#	src/main/scala/edu/ie3/simona/config/OutputConfig.scala
staudtMarius added a commit that referenced this issue May 7, 2025
@staudtMarius
Merge branch 'dev' into ms/#53-upgrate-to-scala3
91ffe82 
# Conflicts:
#	src/main/scala/edu/ie3/simona/config/RuntimeConfig.scala
#	src/main/scala/edu/ie3/simona/model/participant/BmModel.scala
staudtMarius added a commit that referenced this issue May 9, 2025
@staudtMarius
Merge branch 'refs/heads/dev' into ms/#53-upgrate-to-scala3
26c633e 
# Conflicts:
#	CHANGELOG.md
#	build.gradle
#	src/main/scala/edu/ie3/simona/model/participant/load/profile/LoadProfileStore.scala
#	src/main/scala/edu/ie3/simona/model/participant/load/random/RandomLoadParamStore.scala
#	src/test/scala/edu/ie3/simona/model/participant/load/profile/LoadProfileStoreSpec.scala
#	src/test/scala/edu/ie3/simona/model/participant/load/random/RandomLoadParamStoreSpec.scala
staudtMarius added a commit that referenced this issue May 12, 2025
@staudtMarius
Merge branch 'dev' into ms/#53-upgrate-to-scala3
4c4133c
staudtMarius added a commit that referenced this issue May 12, 2025
@staudtMarius
Merge remote-tracking branch 'origin/ms/#53-upgrate-to-scala3' into m…
27fa1d7 
…s/ReCoDe

# Conflicts:
#	src/main/scala/edu/ie3/simona/config/RuntimeConfig.scala
#	src/main/scala/edu/ie3/simona/config/SimonaConfig.scala
#	src/main/scala/edu/ie3/simona/sim/setup/ExtSimSetupData.scala
staudtMarius added a commit that referenced this issue May 12, 2025
@staudtMarius
Merge branch 'dev' into ms/#53-upgrate-to-scala3
4b6ed3f
staudtMarius added a commit that referenced this issue May 13, 2025
@staudtMarius
Merge pull request #1105 from ie3-institute/ms/#53-upgrate-to-scala3
7936abf 
Upgrade `scala2` to `scala3`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johanneshiry johanneshiry

@staudtMarius staudtMarius

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade scala2 to scala3. ie3-institute/simona
Switching to scala 3. ie3-institute/simona
5 participants
@TheElectronWill @sebastian-peter @t1b00 @johanneshiry @staudtMarius