Skip to content

Create trait for ThermalStorageCalculations #1474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 8, 2025
Merged

Create trait for ThermalStorageCalculations #1474

merged 6 commits into from
Aug 8, 2025

Conversation

danielfeismann
Copy link
Member

@danielfeismann danielfeismann commented Jul 30, 2025 •
edited
Loading

resolves #1473

@danielfeismann danielfeismann self-assigned this Jul 30, 2025
@danielfeismann danielfeismann added the code quality Code readability or efficiency is improved label Jul 30, 2025
@danielfeismann danielfeismann added this to the Version 4.1 milestone Jul 30, 2025
@danielfeismann danielfeismann marked this pull request as ready for review July 30, 2025 18:25
This was referenced Jul 30, 2025
Open
Merged
staudtMarius and others added 3 commits July 31, 2025 16:00
@staudtMarius
Merge branch 'dev' into df/#1473-thermalStorageCalculations
ea3390f
@danielfeismann
Merge branch 'dev' into df/#1473-thermalStorageCalculations
4acea46 
# Conflicts:
#	CHANGELOG.md
#	src/main/scala/edu/ie3/simona/model/thermal/CylindricalThermalStorage.scala
@danielfeismann
Merge branch 'dev' into df/#1473-thermalStorageCalculations
0d33e79 
# Conflicts:
#	CHANGELOG.md
staudtMarius
staudtMarius previously approved these changes Aug 8, 2025
View reviewed changes
Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@staudtMarius
Copy link
Member

@danielfeismann Is there a way to skip the sonarqube test coverage? Else, you need to increase the coverage.

@danielfeismann
Copy link
Member Author

Yes, thats possible. But let's see if some tests for SquantsUtils will convince the quality gate

staudtMarius
staudtMarius approved these changes Aug 8, 2025
View reviewed changes
Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@danielfeismann danielfeismann merged commit 73443ce into dev Aug 8, 2025
4 of 5 checks passed
@danielfeismann danielfeismann deleted the df/#1473-thermalStorageCalculations branch August 8, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@staudtMarius staudtMarius staudtMarius approved these changes

Assignees

@danielfeismann danielfeismann

Labels

code quality Code readability or efficiency is improved

Projects

None yet

Milestone

Version 4.1

Development

Successfully merging this pull request may close these issues.

Create trait for ThermalStorageCalculations

2 participants

@danielfeismann @staudtMarius