Skip to content

chore: stricter deprecation for layout.spring() and layout.svd() #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

maelle
Copy link
Contributor

@maelle maelle commented Sep 10, 2024

This was validated by @szhorvat and @ntamas in #685 but @krlmlr we might want to see whether it creates revdeps failures.

@maelle maelle added lifecycle Deprecating old APIs hackathon-topic 📆 labels Sep 10, 2024
Copy link
Contributor

aviator-app bot commented Sep 10, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This pull request is currently open (not queued).

How to merge

To merge this PR, comment /aviator merge or add the mergequeue label.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@maelle maelle marked this pull request as draft September 10, 2024 13:45
@szhorvat
Copy link
Member

@krlmlr Should this be included in 2.2.0 and in revdepchecks?

@krlmlr
Copy link
Contributor

krlmlr commented Mar 18, 2025

We discussed with Maëlle, let's give it another couple of years.

@maelle
Copy link
Contributor Author

maelle commented Mar 20, 2025

Or months 😇 Should I close this in the meantime?

@krlmlr
Copy link
Contributor

krlmlr commented Mar 20, 2025

Why would you close it? Draft PRs are fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle Deprecating old APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants