Skip to content

Refactor/clean up optional 2 #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from
Closed

Conversation

szhorvat
Copy link
Member

@szhorvat szhorvat commented Nov 3, 2024

Just testing, don't merge.

…rated code and remove support for deprecated array3 type
chore: fix some spelling mistakes
refactor: minor readability cleanup in igraph_decompose()
doc: more documentation improvements
doc: several documentation improvements and cross-referencing
chore: fix typo in error message
docs: community_optimal_modulairty() does support directed graphs
chore: do not warn about unknown warning options with legacy Intel compiler
fix: validate sample size in igraph_motifs_randesu_estimate()
chore: fix typo in comment
fix: some BIPARTITE_TYPES parameters were incorrectly marked as optional
refactor: use OPTIONAL instead of =NULL in interfaces
refactor: minor readability cleanup in matching functions
fix: `igraph_bipartite_projection_size()` now validates the bipartite `types` vector
fix: some weights parameters were incorrectly marked as OPTIONAL in functions.yaml
fix: mark some optional weight parameters as OPTIONAL in functions.yaml
fix: type -> types in is_bipartite interface
…n_size()`

This parameter is optional in R, but not in C. Therefore the C interface definition doesn't provide a default or OPTIONAL marker.
interface: add more missing OPTIONAL markers
These checks are added automatically by Stimulus for OPTIONAL parameters
interface: even more missing OPTIONAL markers
Copy link
Contributor

aviator-app bot commented Nov 3, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was closed without merging. If you still want to merge this PR, re-open it.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@szhorvat szhorvat force-pushed the refactor/clean-up-OPTIONAL-2 branch from 1d822ff to 506dd8e Compare November 3, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant