feat!: Accept numeric edge IDs #758
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krlmlr
force-pushed
the
f-223-from-df-numeric
branch
from
8b5351c to
8348df7
Compare
|
@thomasp85: Are you still interested in #193? I noticed I'm making an effort here to convert factors to characters, perhaps we should be doing things the other way round? What behavior would you like to see -- setting and retrieving attributes of type factor? |
krlmlr
force-pushed
the
f-223-from-df-numeric
branch
from
8348df7 to
8cb0740
Compare
Current Aviator status
This pull request is currently open (not queued). How to mergeTo merge this PR, comment
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
krlmlr
force-pushed
the
f-223-from-df-numeric
branch
2 times, most recently
from
e8523db to
e388cfa
Compare
|
Running revdepchecks now. |
|
The impact is severe, but I'll also run with the current main branch to compare. |
krlmlr
force-pushed
the
f-223-from-df-numeric
branch
from
50bbfaf to
314059e
Compare
|
Actually, rerunning one more time with this branch and the broken packages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #223.
This needs a fix of the tests, and a revdepcheck to assess the impact.