Skip to content

Transport improvements from 2025-W20 #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Transport improvements from 2025-W20 #349

wants to merge 10 commits into from

Conversation

khaeru
Copy link
Member

@khaeru khaeru commented May 13, 2025

#328 ← previous PR

How to review

TBA

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation.
  • Update doc/whatsnew.

@khaeru khaeru added enh New features or functionality transport MESSAGEix-Transport variant or transport in the base model labels May 13, 2025
@khaeru khaeru mentioned this pull request May 13, 2025
4 tasks
Copy link

codecov bot commented May 13, 2025

Codecov Report

Attention: Patch coverage is 21.05263% with 15 lines in your changes missing coverage. Please review.

Project coverage is 71.1%. Comparing base (4bc1cfa) to head (ddb1cbf).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
message_ix_models/project/engage/workflow.py 18.7% 13 Missing ⚠️
message_ix_models/model/transport/workflow.py 0.0% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #349     +/-   ##
=======================================
- Coverage   72.0%   71.1%   -1.0%     
=======================================
  Files        243     243             
  Lines      19451   19444      -7     
=======================================
- Hits       14011   13826    -185     
- Misses      5440    5618    +178     
Files with missing lines Coverage Δ
message_ix_models/model/config.py 93.1% <100.0%> (+0.2%) ⬆️
...age_ix_models/tests/model/transport/test_report.py 67.9% <ø> (-24.9%) ⬇️
message_ix_models/model/transport/workflow.py 20.7% <0.0%> (-62.0%) ⬇️
message_ix_models/project/engage/workflow.py 40.6% <18.7%> (-2.3%) ⬇️

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@khaeru khaeru force-pushed the transport/2025-w20 branch 2 times, most recently from de2037a to ddb1cbf Compare May 19, 2025 07:25
@khaeru khaeru added this to the 2025-07 milestone May 28, 2025
khaeru and others added 10 commits May 28, 2025 14:17
- Improve from message_ix_models.project.engage.
- Reference .model.Config.relation_global_co2 via Context, instead of
  hard-coded RELATION_GLOBAL_CO2.
- Use metaclass to construct an Enum subtype for e.g. SSP_2024.
- Update tests.
This change avoids sporadic local mypy failures via pre-commit.
@khaeru khaeru force-pushed the transport/2025-w20 branch from 6e0b3ae to b293ee2 Compare May 28, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enh New features or functionality transport MESSAGEix-Transport variant or transport in the base model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants