Add no_panic attribute for FromPrimitive #169
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new attribute:
#[num_enum(from_primitive(no_panic))]
, with alternative syntax of#[num_enum(from_primitive(no_panic=true))]
.this configuration is off by default.
this configuration generates a
#[no_panic::no_panic]
attribute on the (from this crate https://docs.rs/no-panic/latest/no_panic/)from_primitive()
methods generated by#[derive(FromPrimitive)]
I made A POC that's works on my machine with manual tests.
If you are willing to accept such feature, I will add the necessary tests & docs.
I am open to make changes according to feedback.
example code from my project: