for issue: #584 #1251
Closed
for issue: #584 #1251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull request description It.s seems the equal() method in the abstract class isn't designed properly and I make some change in these abstract classes and their subclasses. for issue: iluwatar#584
iluwatar
requested changes
Jul 4, 2020
There was a problem hiding this comment.
I agree that design-wise this change looks good since we have abstract base classes. However when you try to build it it gives some checkstyle errors that should be fixed.
[INFO] --- maven-checkstyle-plugin:3.1.0:check (validate) @ prototype ---
[WARNING] src/main/java/com/iluwatar/prototype/OrcMage.java:[57,13] (whitespace) WhitespaceAround: WhitespaceAround: '==' is not followed by whitespace. Empty blocks may only be represented as {} when not part of a multi-block statement (4.1.3)
[WARNING] src/main/java/com/iluwatar/prototype/OrcBeast.java:[57,13] (whitespace) WhitespaceAround: WhitespaceAround: '==' is not followed by whitespace. Empty blocks may only be represented as {} when not part of a multi-block statement (4.1.3)
[WARNING] src/main/java/com/iluwatar/prototype/ElfBeast.java:[57,13] (whitespace) WhitespaceAround: WhitespaceAround: '==' is not followed by whitespace. Empty blocks may only be represented as {} when not part of a multi-block statement (4.1.3)
[WARNING] src/main/java/com/iluwatar/prototype/OrcWarlord.java:[57,13] (whitespace) WhitespaceAround: WhitespaceAround: '==' is not followed by whitespace. Empty blocks may only be represented as {} when not part of a multi-block statement (4.1.3)
[WARNING] src/main/java/com/iluwatar/prototype/ElfWarlord.java:[57,13] (whitespace) WhitespaceAround: WhitespaceAround: '==' is not followed by whitespace. Empty blocks may only be represented as {} when not part of a multi-block statement (4.1.3)
[WARNING] src/main/java/com/iluwatar/prototype/ElfMage.java:[57,13] (whitespace) WhitespaceAround: WhitespaceAround: '==' is not followed by whitespace. Empty blocks may only be represented as {} when not part of a multi-block statement (4.1.3)
|
Please find the review comments above. When you're ready for another review please comment on this issue. Thanks! |
|
@jasciiz The pull request has remained inactive and is about to be closed. Please comment if you're still working on it. |
|
Closed due to inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
It.s seems the equal() method in the abstract class isn't designed properly and I make some change in these abstract classes and their subclasses.
for issue: #584
Pull request title
Pull request description