Skip to content

Update Pull Requests CI trigger behaviour #1568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2020
Merged

Conversation

ohbus
Copy link
Contributor

@ohbus ohbus commented Oct 16, 2020

Improve Pull Request trigger behaviour

Why does it need any improvement?

⛔ Reopened Pull Request will not start to build automatically
⛔ Labelling and unlabelling them will not start a build

The Pull Request Builder will now automatically get triggered on the following events:

  • opened
  • reopened
  • synchronize
  • labeled
  • unlabeled

These additional behaviours will work on top of the existing behaviour of:

✔️ Opening a new Pull Request.
✔️ Pushing a new commit to existing Pull Request.

@ohbus ohbus changed the title Update Pull Requests trigger behaviour Update Pull Requests CI trigger behaviour Oct 16, 2020
@ohbus
Copy link
Contributor Author

ohbus commented Nov 8, 2020

Hey @iluwatar Please review this.

@iluwatar iluwatar added this to the 1.24.0 milestone Nov 28, 2020
@iluwatar iluwatar merged commit fcd7785 into iluwatar:master Nov 28, 2020
@iluwatar
Copy link
Owner

Thanks @ohbus for this improvement! Since you've done several high quality pull requests already, I'd like to invite you to the core team. Contributor access gives you push access to the repository and makes you able to improve things on your own, review/merge pull requests etc. Of course you'll have my full support where needed. Do you accept?

@ohbus
Copy link
Contributor Author

ohbus commented Nov 30, 2020

Thanks @ohbus for this improvement! Since you've done several high quality pull requests already, I'd like to invite you to the core team. Contributor access gives you push access to the repository and makes you able to improve things on your own, review/merge pull requests etc. Of course you'll have my full support where needed. Do you accept?

Thank you so much for this honour ❤️😄❤️ I'm very delighted to accept your request.

Looking forward to collaborate to make greater things!

@iluwatar
Copy link
Owner

Invites sent and looking forward to collaborate as well. In addition to Github we can use Gitter for chats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants