Refactor Prototype pattern (Closes #584) #1970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonatankarp
force-pushed
the
update_prototype_pattern
branch
from
67bb828 to
cf41a94
Compare
yonatankarp
force-pushed
the
update_prototype_pattern
branch
2 times, most recently
from
8434428 to
700b2be
Compare
yonatankarp
commented
Apr 20, 2022
| @@ -1,2 +1,2 @@ | |||
| lombok.log.fieldName = LOGGER | |||
|
|
|||
| lombok.addLombokGeneratedAnnotation = true | |||
There was a problem hiding this comment.
Exclude Lombok auto-generated code from code-coverage
yonatankarp
force-pushed
the
update_prototype_pattern
branch
from
700b2be to
0a73b52
Compare
…watar#584) This commit refactors the Prototype pattern by making it Cloneable and thus inheriting the clone() method to its subclasses which removes code duplications.
yonatankarp
force-pushed
the
update_prototype_pattern
branch
from
0a73b52 to
eae3a3a
Compare
|
SonarCloud Quality Gate failed. |
iluwatar
approved these changes
Sep 8, 2022
|
This is a good refactoring that reduces the amount of boilerplate code. The code coverage is on a good level (75% on new code) even though Sonar is complaining. |
|
Thank you for the prototype pattern refactoring! 🎉 @all-contributors please add @yonatankarp for code |
|
I've put up a pull request to add @yonatankarp! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the Prototype pattern by making it
Cloneableand thus inheriting theclone()method to its subclasses which removes code duplications.