-
-
Notifications
You must be signed in to change notification settings - Fork 27k
Add checkstyle into maven #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checkstyle into maven #246
Conversation
In case you didnt know: |
travis failed because log is too long and it assumed that this is due to test failure. |
Should I do you think reformat java files according to styling guides? |
Ohh now i get it... didnt think travis would fail just because the file is too large. We dont really need the warnings when travis is building the project right? |
Please catch up the branch with origin/master and I will review. Is there an issue for this? |
# Conflicts: # pom.xml
Synced with master. Please note that checkstyle is "off" and will not report anything. Each java file need to be aligned according to the rules of checkstyle. It can be turned on by switching flag to |
Yes once we format all code we will set the flag |
Add checkstyle into maven #224
Thanks @zafarella |
* Edited couple answers in the Network section * Edited Latency, Throughput and bandwidth * Edited few more answers in the Linux section * typos * git rebase usecase update
This will add checkstyle plugin. It will not fail the build, but print warnings.
Align with styles could be done in separate branch.