Skip to content

Add checkstyle into maven #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 12, 2015

Conversation

zafarella
Copy link
Contributor

This will add checkstyle plugin. It will not fail the build, but print warnings.
Align with styles could be done in separate branch.

@markusmo3
Copy link
Contributor

In case you didnt know:
https://google.github.io/styleguide/javaguide.html#s2.3.1-whitespace-characters
TL;DR Java devs hate Tabs, dont ask me why...
Thats also why travis fails.

@zafarella
Copy link
Contributor Author

travis failed because log is too long and it assumed that this is due to test failure.
Local mvn validate successes but bunch of warnings, coz code is not styled according rules.

@zafarella
Copy link
Contributor Author

Should I do you think reformat java files according to styling guides?

@markusmo3
Copy link
Contributor

Ohh now i get it... didnt think travis would fail just because the file is too large.
Formating all the code? Thats a huge task. I'd suggest muting all the warnings and only printing the error (if thats possible with the maven checkstyle plugin).

We dont really need the warnings when travis is building the project right?
I hope im right :S

@iluwatar
Copy link
Owner

Please catch up the branch with origin/master and I will review. Is there an issue for this?

@zafarella
Copy link
Contributor Author

Synced with master. Please note that checkstyle is "off" and will not report anything. Each java file need to be aligned according to the rules of checkstyle. It can be turned on by switching flag to <consoleOutput>false</consoleOutput> to true in parent/root pom.

@npathai
Copy link
Contributor

npathai commented Sep 11, 2015

Yes once we format all code we will set the flag

iluwatar added a commit that referenced this pull request Sep 12, 2015
@iluwatar iluwatar merged commit a033c07 into iluwatar:master Sep 12, 2015
@iluwatar
Copy link
Owner

Thanks @zafarella

pratigya0 pushed a commit to pratigya0/java-design-patterns that referenced this pull request Aug 3, 2023
* Edited couple answers in the Network section

* Edited Latency, Throughput and bandwidth

* Edited few more answers in the Linux section

* typos

* git rebase usecase update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants