Active Record Pattern #79 #3087
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluwatar
requested changes
Nov 10, 2024
active-record/database.db
Outdated
There was a problem hiding this comment.
Is this file necessary, or is created on demand?
active-record/pom.xml
Outdated
Comment on lines
42
to
43
| <!-- <optional/> Removed --> | ||
| <version>1.18.30</version> <!-- Added --> |
There was a problem hiding this comment.
We should use the version from the parent
active-record/pom.xml
Outdated
Comment on lines
50
to
54
| <dependency> | ||
| <groupId>org.xerial</groupId> | ||
| <artifactId>sqlite-jdbc</artifactId> | ||
| <version>3.46.0.0</version> | ||
| </dependency> |
There was a problem hiding this comment.
Using H2 database is highly recommended (see https://github.com/iluwatar/java-design-patterns/wiki/10.-Technology-selections)
| * Find a user by ID. | ||
| */ | ||
|
|
||
| public static User findById(int id) throws SQLException { |
update-header.sh
Outdated
| # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| # THE SOFTWARE. | ||
| # | ||
|
|
There was a problem hiding this comment.
Not sure if this script is necessary?
|
Thanks for the cr! Will look into it |
…atterns into activerecord merging prepullrequest changes
|
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
bot
added
the
status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds active record pattern
Close #79