-
-
Notifications
You must be signed in to change notification settings - Fork 27k
Caching pattern: Cache-Aside #495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@christofferh the implementation looks good. Please update the documentation so we can proceed with the merge. |
* Cache-Aside | ||
*/ | ||
public void useCacheAsideStategy() { | ||
System.out.println("# CachingPolicy.ASIDE"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason for not using logging framework like SLF4J or LOG4J Or Common logging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chinnachalam you are right, using a logging framework would give some advantages such as ability to redirect output and filter output based on logging levels. But I think we should handle this issue on a more general level since there are multiple patterns not using a logging framework at the moment. Would you raise an issue about this matter, please?
Thank you @christofferh for this addition 👍 |
Implementation of #440, (+ minor style fixes)
I'll update documentation & UML once the solution has been reviewed and approved.