Skip to content

Caching pattern: Cache-Aside #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 17, 2016
Merged

Conversation

christofferh
Copy link
Contributor

Implementation of #440, (+ minor style fixes)

I'll update documentation & UML once the solution has been reviewed and approved.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 83.995% when pulling b31edda on christofferh:feat/cache-aside into 6026eed on iluwatar:master.

@iluwatar
Copy link
Owner

@christofferh the implementation looks good. Please update the documentation so we can proceed with the merge.

* Cache-Aside
*/
public void useCacheAsideStategy() {
System.out.println("# CachingPolicy.ASIDE");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason for not using logging framework like SLF4J or LOG4J Or Common logging?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chinnachalam you are right, using a logging framework would give some advantages such as ability to redirect output and filter output based on logging levels. But I think we should handle this issue on a more general level since there are multiple patterns not using a logging framework at the moment. Would you raise an issue about this matter, please?

@christofferh
Copy link
Contributor Author

@iluwatar, docs and and diagram added.

Sidenote: +1 for #190, as an intellij user the diagram generation part was not that enjoyable :)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 84.301% when pulling f114b5b on christofferh:feat/cache-aside into 6026eed on iluwatar:master.

@iluwatar iluwatar merged commit 64bdab4 into iluwatar:master Oct 17, 2016
@iluwatar
Copy link
Owner

Thank you @christofferh for this addition 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants