#567 Marker Interface pull request #572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluwatar
requested changes
May 16, 2017
marker/README.md
Outdated
| Use the Marker Interface pattern when | ||
|
|
||
| * you want to identify the special objects from normal objects | ||
| * define a type that is implemented by instances of the marked class, marker annotations can not do that |
marker/README.md
Outdated
| ## Real world examples | ||
|
|
||
| * [javase.7.docs.api.java.io.Serializable](https://docs.oracle.com/javase/7/docs/api/java/io/Serializable.html) | ||
| * [javase.7.docs.api.java.lang.Cloneable](https://docs.oracle.com/javase/7/docs/api/java/lang/Cloneable.html) |
marker/pom.xml
Outdated
| <dependency> | ||
| <groupId>org.junit.jupiter</groupId> | ||
| <artifactId>junit-jupiter-api</artifactId> | ||
| <version>RELEASE</version> |
There was a problem hiding this comment.
Any particular reason why you use JUnit 5 instead of 4? The rest of the project still uses 4. There is an issue #408 about moving to JUnit 5.
marker/src/main/java/Guard.java
Outdated
| @@ -0,0 +1,10 @@ | |||
| /** | |||
| * Created by Alexis on 29-Apr-17. | |||
There was a problem hiding this comment.
Please add proper JavaDoc instead of creator
marker/src/main/java/Thief.java
Outdated
| @@ -0,0 +1,12 @@ | |||
| /** | |||
| * Created by Alexis on 02-May-17. | |||
There was a problem hiding this comment.
Please add proper JavaDoc instead of creator
marker/src/main/java/App.java
Outdated
| if (guard instanceof Permission) { | ||
| guard.enter(); | ||
| } else { | ||
| System.out.println("You have no permission to enter, please leave this area"); |
There was a problem hiding this comment.
Please use logging framework instead of printing to System.out. See issue #502
|
@4lexis you have my review comments. Please notify when you've made the changes. |
|
@iluwatar Here, I made requested changes. |
iluwatar
approved these changes
May 29, 2017
|
Good work @4lexis thank you for the pattern contribution! 👍 |
|
@all-contributors please add @4lexis for code |
|
I've put up a pull request to add @4lexis! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for marker interface pattern #567