Skip to content

Migrate to JUnit5 #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 1, 2018
Merged

Migrate to JUnit5 #689

merged 1 commit into from
Jan 1, 2018

Conversation

amogozov
Copy link
Contributor

Migrate project to JUnit5

  • Switched all modules to use junit platform
  • If it is impossible to convert module to junit 5 engine, use vintage engine instead (run tests as junit4)
  • Should potentially resolve Bump up JUnit version to 5 #408

public class ConnectivityIssue {

private static final String EXCEPTION_CAUSE = "Connection not available";
@Rule public ExpectedException exception = ExpectedException.none();
//@Rule public ExpectedException exception = ExpectedException.none();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented code

exception.expect(Exception.class);
exception.expectMessage(EXCEPTION_CAUSE);
//exception.expect(Exception.class);
//exception.expectMessage(EXCEPTION_CAUSE);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for this leftover, let me submit separate PR

@iluwatar iluwatar merged commit 7f959ed into iluwatar:master Jan 1, 2018
@iluwatar
Copy link
Owner

iluwatar commented Jan 1, 2018

Well done @amogozov Many thanks for this great PR. 👍

@amogozov amogozov mentioned this pull request Jan 2, 2018
@Quantriple
Copy link

Exception in thread "main" java.lang.NoSuchMethodError: org.junit.platform.commons.util.ReflectionUtils.getDefaultClassLoader()Ljava/lang/ClassLoader

I've looked at a lot of ways to change the juit version but I still have an error and ask for help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump up JUnit version to 5
3 participants