Skip to content

Conversation

EscapedGibbon
Copy link
Contributor

No description provided.

stropitek and others added 18 commits September 2, 2025 14:49
* chore: regenerate package-lock and fix related issues

* chore: update image-js

* chore: update cspell

* chore: update node version in CI

* chore: update clsx

* chore: update and simplify cspell action

* chore: update immer

* chore: update react-icons

* chore: build on cloudflare with node 22

* chore: update react
* chore: update prettier

* chore: update eslint

* chore: update typescript

* chore: regenerate package-lock
* feat: add algolia search

* chore: remove unrelated md file

* chore: remove orama
- Put system requirements at the top
- Change slug to `getting-started`
- Change to MDX since it uses React components.
- Remove Vite tutorial
- Proofread
Re-exported with inkscape as plain SVG and optimized with svgo

Closes: #139
@EscapedGibbon EscapedGibbon linked an issue Sep 24, 2025 that may be closed by this pull request
…l-tips-about-transform-parameters-and-options
@EscapedGibbon EscapedGibbon force-pushed the 125-add-page-in-useful-tips-about-transform-parameters-and-options branch from 3fc1c0c to a13b1c3 Compare September 24, 2025 16:19
Copy link

cloudflare-workers-and-pages bot commented Sep 24, 2025

Deploying image-js-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4ff2f94
Status: ✅  Deploy successful!
Preview URL: https://c4de99b8.image-js-docs.pages.dev
Branch Preview URL: https://125-add-page-in-useful-tips.image-js-docs.pages.dev

View logs

@EscapedGibbon EscapedGibbon force-pushed the 125-add-page-in-useful-tips-about-transform-parameters-and-options branch from d059511 to a77814a Compare September 24, 2025 16:25
@EscapedGibbon EscapedGibbon force-pushed the 125-add-page-in-useful-tips-about-transform-parameters-and-options branch from 8a78449 to b48970f Compare September 29, 2025 08:46
@EscapedGibbon EscapedGibbon marked this pull request as ready for review September 29, 2025 09:10
Copy link
Contributor

@stropitek stropitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2025-09-29 at 13 09 15

Why is the value 255 here and not an array for the RGB value?

Also, can you use another color that does not exist in the image yet, it would make it clearer which pixels are not part of the original image and which are.


Basically, with inverse set to true you kind of "revert" an image back to the states that it was before the matrix transformed.

This sentence is not very clear. I think you can remove it, what you explain before it is already clear.


When true, the function automatically calculates the required output dimensions.

I think you have to remind what happens when false, that is that size of destination = size of source.

There are also some interactions / incompatibilities between width, height and fullImage. I suppose you are not supposed to specify fullImage to true and also width, height together. What happens in that case?

@EscapedGibbon EscapedGibbon force-pushed the 125-add-page-in-useful-tips-about-transform-parameters-and-options branch from 6cca264 to 83f7514 Compare September 30, 2025 07:53
@EscapedGibbon
Copy link
Contributor Author

EscapedGibbon commented Sep 30, 2025

Why is the value 255 here and not an array for the RGB value?

It seems the idea was to have a gray background, so one value was enough.

There are also some interactions / incompatibilities between width, height and fullImage. I suppose you are not supposed to specify fullImage to true and also width, height together. What happens in that case?

fullImage will use width and height that was calculated and neglects width and height values.

@EscapedGibbon EscapedGibbon merged commit 690c078 into main Sep 30, 2025
9 checks passed
@EscapedGibbon EscapedGibbon deleted the 125-add-page-in-useful-tips-about-transform-parameters-and-options branch September 30, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add page in Useful tips about transform() parameters and options
3 participants