Skip to content

Remove feature gate on the std feature #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Remove feature gate on the std feature #213

merged 1 commit into from
Jan 7, 2022

Conversation

paolobarbolini
Copy link
Contributor

@paolobarbolini paolobarbolini commented Jan 7, 2022

This improves the decode performance to up to 40%. Am I missing something? I wouldn't expect something this simple to add such a big change 😅.
The feature gate was added by #196, but no std feature is present in the Cargo.toml, so the multithreaded worker would never get used.

@paolobarbolini
Copy link
Contributor Author

Force pushed to change email

@fintelia
Copy link
Contributor

fintelia commented Jan 7, 2022

The alternative would be to add the std feature to Cargo.toml, but I think your way is a better option seeing as #196 points out that the crate cannot actually work without the standard library.

@paolobarbolini
Copy link
Contributor Author

The alternative would be to add the std feature to Cargo.toml, but I think your way is a better option seeing as #196 points out that the crate cannot actually work without the standard library.

It could be added in 0.3.0

@fintelia fintelia merged commit 55a4a9a into image-rs:master Jan 7, 2022
wartmanm pushed a commit to wartmanm/jpeg-decoder that referenced this pull request Sep 15, 2022
Remove feature gate on the std feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants