Skip to content

Fix a bdv function #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix a bdv function #106

wants to merge 2 commits into from

Conversation

CellKai
Copy link
Contributor

@CellKai CellKai commented Jul 25, 2025

The original function does not work as it is missing several parameters.

Copy link

codecov bot commented Jul 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25%. Comparing base (26f64c9) to head (4bcf768).

Additional details and impacted files
@@          Coverage Diff          @@
##           master   #106   +/-   ##
=====================================
  Coverage      25%    25%           
=====================================
  Files          25     25           
  Lines        1688   1686    -2     
=====================================
  Hits          421    421           
+ Misses       1267   1265    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ehrenfeu
Copy link
Member

Technically speaking, this will trigger a new major version (2.0.0), as it modifies an existing public interface.

Could you explain the idea / reason in the PR in a few words please?

@CellKai
Copy link
Contributor Author

CellKai commented Jul 25, 2025

Certainly :) The original function does not work as it is missing several parameters.
I took a look at some scripts in imcf-scripts-internal that might have been using this function, but could not find any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants