Add contact and mpc conditions #47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-frey
force-pushed
the
changes-for-rve-conditions
branch
from
a053972 to
daa88a6
Compare
m-frey
force-pushed
the
changes-for-rve-conditions
branch
from
daa88a6 to
268c249
Compare
There was a problem hiding this comment.
Thanks for the contribution @m-frey, I left some comments.
Can you please also add test case(s) covering your changes?
I am completely fine with adding these new BC types, but just to note, you can specify "special" BC types also directly in your script:
cubit.add_node_set(item, bc_description="NUMDOF 3 ...", bc_section="MY SPECIAL 4C BC SECTION")| @@ -255,6 +259,9 @@ class BoundaryConditionType(Enum): | |||
| beam_to_solid_surface_meshtying = auto() | |||
| beam_to_solid_surface_contact = auto() | |||
| solid_to_solid_surface_contact = auto() | |||
| micro_model_boundary_surface = auto() | |||
| periodic_rve_edge = auto() | |||
There was a problem hiding this comment.
What about periodic RVE surfaces? Is this yet to come?
| @@ -255,6 +259,9 @@ class BoundaryConditionType(Enum): | |||
| beam_to_solid_surface_meshtying = auto() | |||
| beam_to_solid_surface_contact = auto() | |||
| solid_to_solid_surface_contact = auto() | |||
| micro_model_boundary_surface = auto() | |||
| periodic_rve_edge = auto() | |||
| line_mortar_contact = auto() | |||
There was a problem hiding this comment.
Lets stick to the current convention and name this solid_to_solid_line_contact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced support for boundary conditions:
micro_model_boundary_surfaceperiodic_rve_edgeline_mortar_contact