-
Notifications
You must be signed in to change notification settings - Fork 9
Add cosserat curve #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cosserat curve #148
Conversation
3d4d85e
to
ff8f3d9
Compare
@knarfnitram can you have a look, this should be the full functionality of the CosseratCurve module. I improved some internal details and the test suite should now cover most of the functionality. @davidrudlstorfer this module is tested with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice that you started with the pytest
framework @isteinbrecher!
The changes look really nice! I have a few remarks (unused variables and commented code) and a few small discussions regarding the change to pytest
.
You do not need to apply pytest
suggestions in this PR - I am happy to adjust things once more tests move to pytest
.
P.S.: I also did not look into the cosserat curve and simply reviewed the testing
d29a6f6
to
3b8b94e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the warping by Cosserat curve to MeshPy @isteinbrecher .
I have only a few remarks.
Looks good! I've added the points regarding pytest to the issue #119 and I'll work on them soon |
47a9576
to
f0c1e16
Compare
f0c1e16
to
e230329
Compare
e230329
to
511b9b6
Compare
Add a new submodule
cosserat_curve
that an be used to describe general Cosserat curves with minimal twist.