Skip to content

Add cosserat curve #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Dec 12, 2024
Merged

Conversation

isteinbrecher
Copy link
Collaborator

Add a new submodule cosserat_curve that an be used to describe general Cosserat curves with minimal twist.

@isteinbrecher isteinbrecher force-pushed the cosserat-curve branch 7 times, most recently from 3d4d85e to ff8f3d9 Compare December 11, 2024 09:03
@isteinbrecher isteinbrecher changed the title Draft: Add cosserat curve Add cosserat curve Dec 11, 2024
@isteinbrecher
Copy link
Collaborator Author

@knarfnitram can you have a look, this should be the full functionality of the CosseratCurve module. I improved some internal details and the test suite should now cover most of the functionality.

@davidrudlstorfer this module is tested with pytest, I simply copied the relevant utility functions in tests/utils.py to also work with pytest.

Copy link
Collaborator

@davidrudlstorfer davidrudlstorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice that you started with the pytest framework @isteinbrecher!

The changes look really nice! I have a few remarks (unused variables and commented code) and a few small discussions regarding the change to pytest.

You do not need to apply pytest suggestions in this PR - I am happy to adjust things once more tests move to pytest.

P.S.: I also did not look into the cosserat curve and simply reviewed the testing

@isteinbrecher isteinbrecher force-pushed the cosserat-curve branch 3 times, most recently from d29a6f6 to 3b8b94e Compare December 11, 2024 17:05
Copy link
Collaborator

@knarfnitram knarfnitram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the warping by Cosserat curve to MeshPy @isteinbrecher .

I have only a few remarks.

@davidrudlstorfer
Copy link
Collaborator

Looks good! I've added the points regarding pytest to the issue #119 and I'll work on them soon

@isteinbrecher isteinbrecher merged commit 144a59e into imcs-compsim:main Dec 12, 2024
10 checks passed
@isteinbrecher isteinbrecher deleted the cosserat-curve branch December 12, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants