-
Notifications
You must be signed in to change notification settings - Fork 9
Update latest supported python release to 3.13 #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Pipelines passed. The only weird thing is that the all of the python3.13 pipelines took significantly longer than the python3.10 ones. EDIT: We should maybe consider an own action for installing MeshPy, then we could easily see if this extra time is in the setup of MeshPy or the tests (here it is in the setup) |
There are also some deprecation warnings. I am marking this as draft for now. |
I've actually wanted to try this out yesterday during my investigation of the failing code checks. This is really nice and we should add 3.13 ASAP. Regarding the deprecation warnings - which one do you mean? As far as I can see no deprecation warnings are related to Python 3.13 or MeshPy (directly). I think we could merge this in its current form |
Good, then let't see that we can merge this soon! I had a look and the newly introduced warnings are the following (non are related to actual MeshPy code):
I will take care of the first one and will talk to @clemens-fricke (for full reference also tagging @j042) about the relevance of the others. The only reason why I would wait for now is that splinepy only provides pre-build wheels for python<3.12, so pip is building the underlying C++ code in each testing job, which causes the jobs to take between 8 and 20 minutes, compared to the 1,5-3 minutes for older python versions (I am actually amazed that this works, but would like to keep the low testing time if possible). I have already contacted to the splinepy developers and they will see if they can publish pre-build wheels for python3.13. |
Ahh yeah, that was the reason why we postponed the integration of the 3.13 version. If I have time, I will look into it... |
Set the latest supported python version to 3.13.