Skip to content

Conversation

drinkcoffee
Copy link
Contributor

This PR removes the random number generation code from main. The code in main at present has issues and was to be replaced with the code on random2 branch. However, the code in the random2 branch requires the creation of a off-chain service (and has a few small issues). There is currently not sufficient customer demand to create such a service. Hence, this PR:

  • Removes all random number generation source code
  • Removes all random number generation test code.
  • Updates the readme file in the contracts/ random directory to indicate that Immutable has investigated on-chain random, and points customers to the random2 branch, in particular the thread model document.

@drinkcoffee drinkcoffee requested review from ermyas and ipekt June 26, 2024 08:11
Copy link

Remove random number generation code

Generated at commit: 09d0462d2b964e3cc2c8b1ba8a4545f054343f19

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
0
0
11
27
40
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@drinkcoffee drinkcoffee merged commit 92705c2 into main Jun 26, 2024
@drinkcoffee drinkcoffee deleted the peter/random3 branch May 15, 2025 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants