feat: GFI-82: Allow USDC Swap Hops #2530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 5bf1207.
☁️ Nx Cloud last updated this comment at |
pano-skylakis
previously approved these changes
Feb 18, 2025
…le/ts-immutable-sdk into task/GFI-82-allow-USDC-swap-hops
pano-skylakis
approved these changes
Feb 19, 2025
|
|
||
| export const USDT_IMMUTABLE_MAINNET: ERC20 = { | ||
| chainId: IMMUTABLE_MAINNET_CHAIN_ID, | ||
| address: '0x68bcc7F1190AF20e7b572BCfb431c3Ac10A936Ab', |
There was a problem hiding this comment.
Double checked both addys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi👋, please prefix this PR's title with:
breaking-change:if you have introduced modification that necessitates immediate adjustments by this SDK's users to their applications, clients, or integrations to avert disruptions to existing features or functionalities.feat:,fix:,refactor:,docs:, orchore:.Summary
Add USDC to "common routing tokens" allowing it to be considered as a hop for swaps.
Further justification for this is that we recommend games set up a USDC LP for their token: https://docs.immutable.com/guides/zkevm/game-currencies/liquidity-pools/#set-up-your-liquidity-pool-with-quickswap
Also added USDT as some tokens only have USDT pools e.g. https://quickswap.exchange/#/analytics/v3/token/0x699797abcdc2e20165fE4bAC5efbAa652490E6E2
Ran some tests locally and adding two more common routing tokens only increased the quoting time by about 50ms.
Detail and impact of the change
Added
Changed
Deprecated
Removed
Fixed
Security
Anything else worth calling out?