Skip to content

Conversation

imx-mikhala
Copy link
Contributor

@imx-mikhala imx-mikhala commented Feb 25, 2025

Hi👋, please ensure the PR title follows the below standards:

  • PR is titled with conventional commit style naming: type(scope): message. For example: feat(passport): my new feature
  • If you have introduced modification that necessitates immediate adjustments by this SDK's users to their applications, clients, or integrations to avert disruptions to existing features or functionalities, add a ! after the type(scope), for example feat(passport)!: my new breaking feature

Summary

  • Check isLoggedIn before calling loginWithOIDC to prevent unnecessary calls to the Magic OIDC endpoint

Detail and impact of the change

Added

Changed

Deprecated

Removed

Fixed

Security

Anything else worth calling out?

@imx-mikhala imx-mikhala changed the title chore(passport): Check isLoggedIn before calling loginWithOIDC in v1 chore(passport): Check isLoggedIn before calling loginWithOIDC Feb 25, 2025
@imx-mikhala imx-mikhala marked this pull request as ready for review February 26, 2025 00:01
@imx-mikhala imx-mikhala requested a review from a team as a code owner February 26, 2025 00:01
Copy link
Contributor

@pano-skylakis pano-skylakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imx-mikhala imx-mikhala merged commit 6f97f3b into legacy-v1 Feb 26, 2025
@imx-mikhala imx-mikhala deleted the ID-3277-legacy branch February 26, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants