Skip to content

Conversation

haydenfowler
Copy link
Collaborator

This PR reverts #2651, as this approach gives less control to consumers of the SDK. Consumers should ensure that the login method is only being called once, otherwise they risk the loginCallback failing with a No matching state found in storage error.

@haydenfowler haydenfowler requested a review from a team as a code owner September 1, 2025 23:51
@haydenfowler haydenfowler changed the title Revert "feat(passport): ID-3764 Debounce login" feat(passport): ID-3955 Revert debounce login Sep 1, 2025
Copy link

nx-cloud bot commented Sep 1, 2025

View your CI Pipeline Execution ↗ for commit 9f36e13

Command Status Duration Result
nx affected -t build,lint,test ✅ Succeeded 3m 1s View ↗
nx run-many -p @imtbl/sdk,@imtbl/checkout-widge... ✅ Succeeded 1m 16s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-02 05:36:35 UTC

@haydenfowler haydenfowler added this pull request to the merge queue Sep 3, 2025
Merged via the queue into main with commit b822bf6 Sep 3, 2025
10 checks passed
@haydenfowler haydenfowler deleted the revert-2651-feature/ID-3764-debounce-loginCallback branch September 3, 2025 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants