feat(checkout-widgets): Allow hide header on On-Ramp widget #2723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 1d68c22
☁️ Nx Cloud last updated this comment at |
keithbro-imx
previously approved these changes
Sep 26, 2025
| showMenu, | ||
| customTitle, | ||
| customSubTitle, | ||
| showHeader, |
There was a problem hiding this comment.
Would be a bit better to do the defaulting here but not a blocker
There was a problem hiding this comment.
yeah I thought about this
do you mean showHeader=True or should we default it and then pass it into this component
| showMenu={onrampConfig?.showMenu} | ||
| customTitle={onrampConfig?.customTitle} | ||
| customSubTitle={onrampConfig?.customSubTitle} | ||
| showHeader={onrampConfig?.showHeader} |
There was a problem hiding this comment.
@keithbro-imx we could also default it here eg. showHeader={onrampConfig?.showHeader ?? true}
jeetparikh
approved these changes
Sep 30, 2025
priyaleedman-imm
deleted the
task/GFI-1196-allow-hide-header-on-onramp-widget
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://immutable.atlassian.net/browse/GFI-1196
Default
Removed
Note
Adds
showHeaderto On-Ramp config/props to optionally hide the header; iframe container height set to 100%.showHeader?: booleantoOnrampWidgetConfiguration(packages/checkout/sdk/src/widgets/definitions/configurations/onramp.ts).showHeaderfromOnRampWidgettoOnRampMain(packages/checkout/widgets-lib/src/widgets/on-ramp/OnRampWidget.tsx).OnRampMain, addshowHeader?: booleanprop (defaulttrue) and conditionally renderHeaderNavigationviaSimpleLayoutheaderprop (packages/checkout/widgets-lib/src/widgets/on-ramp/views/OnRampMain.tsx).containerStyleheight from565pxto100%(packages/checkout/widgets-lib/src/widgets/on-ramp/views/onRampStyles.ts).ONRAMPconfig includingshowHeader(commented example) (packages/checkout/widgets-sample-app/src/components/ui/checkout/checkout.tsx).Written by Cursor Bugbot for commit 1d68c22. This will update automatically on new commits. Configure here.