Skip to content

feat: android pkce flow using custom tabs #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2023
Merged

feat: android pkce flow using custom tabs #20

merged 1 commit into from
Sep 27, 2023

Conversation

nattb8
Copy link
Collaborator

@nattb8 nattb8 commented Sep 26, 2023

  • Use Custom Chome Tabs when using PKCE flow for Android. If none of the browsers support Custom Tabs Service, it will fall to the external browser
  • Refactored deeplink handling code for Android to use static functions instead of callback

@nattb8 nattb8 requested a review from dom-murray September 26, 2023 23:03
@nattb8 nattb8 merged commit 7276f83 into main Sep 27, 2023
@nattb8 nattb8 deleted the feat/android-pkce-custom-tabs branch September 27, 2023 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suluvai suluvai suluvai approved these changes

@dom-murray dom-murray dom-murray approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nattb8 @suluvai @dom-murray