Skip to content

feat: register offchain, registered offchain and update connect silent to reconnect #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 6, 2023
Merged

feat: register offchain, registered offchain and update connect silent to reconnect #44

merged 7 commits into from
Dec 6, 2023

Conversation

YermekG
Copy link
Contributor

@YermekG YermekG commented Nov 30, 2023

  • DX-2434: Added new nodes IsRegisteredOffchain and RegisteredOffchain
  • DX-2514: Added new node Reconnect
  • DX-2514: Removed redundant code
  • fix: Fixed minor issue and added comments

@YermekG YermekG requested a review from a team November 30, 2023 00:57
@YermekG YermekG assigned suluvai, nattb8 and YermekG and unassigned YermekG Nov 30, 2023
suluvai

This comment was marked as duplicate.

Sign in to view

suluvai
suluvai previously requested changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@suluvai suluvai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yermick, there are sample blueprints we ship along with the Unreal SDK. They will need to be updated to reflect the changes in this PR and also add functionality to test RegisterOffchain and IsRegisteredOffChain methods added in this repo.

@YermekG YermekG force-pushed the DX-2497 branch 3 times, most recently from a461685 to edc8c85 Compare December 1, 2023 01:34
@YermekG
Copy link
Contributor Author

YermekG commented Dec 1, 2023 •
edited
Loading

@Yermick, there are sample blueprints we ship along with the Unreal SDK. They will need to be updated to reflect the changes in this PR and also add functionality to test RegisterOffchain and IsRegisteredOffChain methods added in this repo.

@nattb8 I have updated the bridge UE asset via 4.26.2 version in order to guarantee its relevance across all UE versions. I added registerOffchain and isRegisterOffchain routine to the blueprint example files. I have tested the changed blueprint in both UE versions 4.26.2 and 5.0.3.

@YermekG YermekG requested review from suluvai and nattb8 December 1, 2023 04:41
@YermekG YermekG dismissed suluvai’s stale review December 1, 2023 04:48

I have updated the sdk according to Parveen's recommendations

@YermekG YermekG force-pushed the DX-2497 branch 2 times, most recently from 84ef758 to 67a3347 Compare December 1, 2023 04:51
@YermekG
feat: added new nodes
10accf4 
* DX-2434: Added new nodes IsRegisteredOffchain and RegisteredOffchain
* DX-2514: Added new node Reconnect
* DX-2514: Removed redundant code
* fix: Fixed minor issue and added comments
@YermekG
chore: updated bridge according to recommendation
36ffd91 
* chore: updated bridge in version ue 4.26.2
@YermekG
fix: reinstated old functionality and updated bridge asset
8414060 
* refactor:  reinstated updated check for credentials
* build: updated bridge asset in ue 4.26.2
* fix: updated methods to match bridge funtionality
@YermekG
fix: updated blueprint examplar to use updated bridge
d6c48e1
@YermekG
feat: added offchain registeration functionality to sdk blueprint exa…
180443f 
…mples
@YermekG
fix: reverted uplugin files changes
2d0506e 
fix: Removed incorrect condition for token getters

Revert "fix: Removed incorrect condition for token getters"

This reverts commit 05f8495.
@YermekG YermekG merged commit 7849c71 into main Dec 6, 2023
@YermekG YermekG deleted the DX-2497 branch December 7, 2023 01:29
@nattb8 nattb8 changed the title feat: added new nodes feat: register offchain, is registered offchain and reconnect functions Dec 14, 2023
@nattb8 nattb8 changed the title feat: register offchain, is registered offchain and reconnect functions feat: register offchain, registered offchain and update connect silent to reconnect Dec 14, 2023
@nattb8 nattb8 added the feature label Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nattb8 nattb8 nattb8 approved these changes

@suluvai suluvai Awaiting requested review from suluvai

Assignees

@suluvai suluvai

@nattb8 nattb8

Labels
feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YermekG @suluvai @nattb8