Skip to content

[DX-2601] fix: chrome custom tabs #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2024
Merged

[DX-2601] fix: chrome custom tabs #59

merged 1 commit into from
Jan 24, 2024

Conversation

nattb8
Copy link
Collaborator

@nattb8 nattb8 commented Jan 24, 2024

Summary

Issue 1

After logging into Passport via Chrome Custom Tabs on certain Android devices, the Chrome Custom Tabs may unexpectedly reappear and dismiss itself.

Fix:

  • Create a dedicated Android activity to launch Chrome Custom Tabs (ImmutableActivity) and handle deep links (RedirectActivity)

Issue 2

On some Xiaomi and Huawei phones, Chrome Custom Tabs may fail to launch on the first try or unless Chrome is manually launched first.

Fix:

  • Launch Chrome Custom Tabs from a different thread

Customer Impact

Developers must update how Android is set up to use PKCE. See public docs for an update.

Other things to consider:

@nattb8 nattb8 requested a review from a team January 24, 2024 20:25
@nattb8 nattb8 enabled auto-merge (squash) January 24, 2024 21:47
@nattb8 nattb8 disabled auto-merge January 24, 2024 21:48
@nattb8 nattb8 merged commit 07469cc into main Jan 24, 2024
@nattb8 nattb8 deleted the fix/android-custom-tabs branch January 24, 2024 21:52
@github-actions github-actions bot added the fix label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants