[DX-2506] feat: new passport login without wallet #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YermekG
force-pushed
the
feat/new_login
branch
from
4753a31 to
5de6316
Compare
YermekG
changed the title
nattb8
reviewed
Jan 25, 2024
nattb8
requested changes
Jan 25, 2024
There was a problem hiding this comment.
[x] Sample blueprints are updated with new SDK changes
- The sample blueprints do not include logging in / connecting using a cached session.
- The Unauthenticated screen must include a Connect button if the user clicks Login on the Authenticated screen. Without connecting, the user cannot use any of the Imx functions. Try Login -> Click on Get Address -> Error
Edit: Add this in another PR
nattb8
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These changes are required to align new login and connectImx functionality with Passport TS SDK
Customer Impact
Connect,ConnectSilent,ConnectPKCEwere removedLogin,ConnectImx,LoginPKCEandConnectImxPKCEAdded
Changed
Removed
Other things to consider:
feat:,fix:,chore:,docs:,refactor:ortest:.