Skip to content

[DX-2716] feat: ability to skip logging out of auth0 in the browser #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

YermekG
Copy link
Contributor

@YermekG YermekG commented Feb 29, 2024

Summary

The SDK's current logout function performs a local logout and also opens the browser to log them out of the browser session. However, some customers might find the browser popup undesirable. To address this issue, a change has been made to allow users to skip logging out of the browser step and only perform a local logout:

  • To skip the Auth0 logout and only perform a local logout, set DoHardLogout to false when calling Logout method/blueprint node.
  • To perform local and Auth0 logout, set the DoHardLogout parameter to true when calling the Logout method/blueprint node. This is the default.

Customer Impact

Developers can now choose not to display the browser pop-up when logging out. However, if they choose this option, users will remain logged into Passport in the browser until the browser session expires.

e.g.

  • User logs into Passport with Google Account A
  • User logs out without the browser popup (DoHardLogout is set to false)
  • User tries to log into Passport again
  • If the Passport session in the browser is:
    • still valid, the user will be automatically logged in as Google Account A
    • no longer valid, the user will go through the full Passport login flow again (choose Google/Email/etc.)

Other things to consider:

@YermekG YermekG requested a review from a team February 29, 2024 02:55
@YermekG YermekG enabled auto-merge (squash) February 29, 2024 03:01
@YermekG YermekG force-pushed the feat/logout branch 2 times, most recently from 8769cb3 to 55634f1 Compare February 29, 2024 03:19
@YermekG YermekG merged commit 38fea8f into main Feb 29, 2024
@YermekG YermekG deleted the feat/logout branch February 29, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants