Skip to content

[DX-2718, DX-2719] fix: removal of redundant data types, save game load on initialisation #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

YermekG
Copy link
Contributor

@YermekG YermekG commented Mar 4, 2024

Summary

  • Removed unused faulty json data types
  • Slightly modified load of passport settings (save game) routine
  • Moved data types to dedicated source code files

Customer Impact

Cleared Immutable log errors in the editor

Fixed

Fixes for misleading in-editor errors

Other things to consider:

  • Prefix your PR title with feat: , fix: , chore: , docs: , refactor: or test: .
  • Sample blueprints are updated with new SDK changes
  • Updated public documentation with new SDK changes (Immutable X and Immutable zkEVM)
  • Replied to GitHub issues

@YermekG YermekG requested a review from a team March 4, 2024 22:56
@YermekG YermekG force-pushed the fix/editor-errors branch 3 times, most recently from 44465ef to 91e3ff7 Compare March 4, 2024 23:11
@YermekG YermekG changed the title [DX-2718, DX-2719] fix: removal of redundant data types, passport sav… [DX-2718, DX-2719] fix: removal of redundant data types, save game load on initialisation Mar 4, 2024
* fix: removed redundant data structures

* fix: modified load of passport settings which tracks if player connected via pkce

* refactor: moved data types and requests data definitions from headers
@YermekG YermekG force-pushed the fix/editor-errors branch from 91e3ff7 to 3d608f5 Compare March 4, 2024 23:36
@YermekG YermekG requested a review from nattb8 March 4, 2024 23:39
@YermekG YermekG merged commit ff34ed4 into main Mar 5, 2024
@github-actions github-actions bot added the fix label Mar 5, 2024
@YermekG YermekG deleted the fix/editor-errors branch March 10, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants