Skip to content

[DX-2735] fix: fixed blui browser closure #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2024
Merged

[DX-2735] fix: fixed blui browser closure #80

merged 1 commit into from
Mar 12, 2024

Conversation

YermekG
Copy link
Contributor

@YermekG YermekG commented Mar 10, 2024

Summary

Fix for CEF browser loading issue primarily addressed on BLUI plugin side within commit. The issue was in improper browser cleanup/closure procedure. CEF requires to have cache files which can only be used by single process(in this case specifically local storage). Whenever, local storage is locked by closing process, a newly created process is blocked and Immutable plugin forced to wait.

Removed

Forceful blui process closure

Other things to consider:

  • Prefix your PR title with feat: , fix: , chore: , docs: , refactor: or test: .
  • Sample blueprints are updated with new SDK changes
  • Updated public documentation with new SDK changes (Immutable X and Immutable zkEVM)
  • Replied to GitHub issues

@YermekG YermekG requested review from a team and nattb8 March 10, 2024 10:51
@YermekG YermekG enabled auto-merge (squash) March 12, 2024 10:23
@YermekG YermekG merged commit 11e8635 into main Mar 12, 2024
@github-actions github-actions bot added the fix label Mar 12, 2024
@YermekG YermekG deleted the fix/blui branch July 25, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants