Recommend first party API before third party plugin for persistent layouts #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skryukov
added a commit
to skryukov/inertia_rails-contrib
that referenced
this pull request
Oct 14, 2024
skryukov
added a commit
to skryukov/inertia_rails-contrib
that referenced
this pull request
Oct 25, 2024
|
Good catch, thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We probably don't want to recommend users install plugins they may not need. The
defineOptionsmacro has been part of Vue since the previous minor release, version 3.3. I've updated the docs to recommend this first, and linking to the plugin version second.Thank you for your work on this project, it is fantastic ❤️