Skip to content
This repository was archived by the owner on Jul 6, 2022. It is now read-only.

Support DELIMITER for MariaDB and MySQL #73

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

gpetrounrt
Copy link

This is my initial attempt to address #72. I am not sure if this is the right approach to fix the issue. There are also a couple of pending issues, one with spaces before END in MariaDB and the other with missing new line before BEGIN in MySQL.

@inferrinizzard
Copy link
Owner

inferrinizzard commented Mar 30, 2022

I've thought about how an implementation for dynamic token input would work and I don't have an efficient solution yet since the RegEx for each language is baked and compiled into one hard-coded string, ie. the delimiter for all languages is always ';'.

Allowing users to dynamically regenerate this entire RegEx with custom delimiters/tokens would definitely be possible but will tank the processing time.

May implement this as an experimental feature once I am back from hiatus / as a part of 5.2.x release.
Thank you for your help on the project! Feel free to share your thoughts on how best to implement this feature :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants