Skip to content

Conversation

mimetypes
Copy link
Contributor

Adjust the license so it matches the official format: https://opensource.org/licenses/MIT
This should fix #13

@Empty2k12
Copy link
Collaborator

Thanks, that was quick. Hacktoberfest has not started yet, so this won't count to your stats :(

I am not sure if it will count if I go ahead and merge it in October, as I think the PR has to be opened in October. What should we do?

Copy link
Collaborator

@Empty2k12 Empty2k12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would also need to be updated here https://github.com/Empty2k12/influxdb-rust/blob/master/Cargo.toml#L8-L10, so Cargo can read the renamed file.

@Empty2k12
Copy link
Collaborator

I just checked The Manifest Format

# This is an SPDX 2.1 license expression for this package. Currently
# crates.io will validate the license provided against a whitelist of
# known license and exception identifiers from the SPDX license list
# 2.4. Parentheses are not currently supported.
#
# Multiple licenses can be separated with a `/`, although that usage
# is deprecated. Instead, use a license expression with AND and OR
# operators to get more explicit semantics.
license = "..."

# If a package is using a nonstandard license, then this key may be specified in
# lieu of the above key and must point to a file relative to this manifest
# (similar to the readme key).
license-file = "..."

Do you think it would make sense to replace license-file = "LICENSE" with license = "MIT" for being extra clear?

@mimetypes
Copy link
Contributor Author

Silly me, I totally forgot about the october part in Hacktoberfest.
The issue just caught my eye by accident, please feel free to handle this how you seem fit, I dont really care that much about the stats.

@mimetypes
Copy link
Contributor Author

Do you think it would make sense to replace license-file = "LICENSE" with license = "MIT" for being extra clear?

Looking at some official crates this does indeed seem like the way to go

@Empty2k12 Empty2k12 added Status: Merge when CI passes This PR has been reviewed and accepted for merge and removed Status: Pending Discussion labels Sep 26, 2019
@Empty2k12
Copy link
Collaborator

Thank you for the change! I appreciate it!

I will go ahead and merge it now, but please feel free to come back anytime (or during October) to get your PRs counting for Octoberfest!

@Empty2k12 Empty2k12 added this to the Release 0.0.5 milestone Sep 26, 2019
@Empty2k12 Empty2k12 merged commit 871ba4f into influxdb-rs:master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crates.io does not detect license correctly
2 participants