Skip to content

fix: update HasFunction method to discern between regular knots and function knots. #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: update HasFunction method to discern between regular knots and function knots. #210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Packages/Ink/InkLibs/InkRuntime/Story.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1816,7 +1816,15 @@ public void ChooseChoiceIndex(int choiceIdx)
public bool HasFunction (string functionName)
{
try {
return KnotContainerWithName (functionName) != null;
Container container = KnotContainerWithName (functionName);
if(container != null) {
return container.content.Any(c =>
c is Ink.Runtime.ControlCommand controlCommand &&
controlCommand.commandType == ControlCommand.CommandType.PopFunction
);
} else {
return false;
}
} catch {
return false;
}
Expand Down