This repository was archived by the owner on Aug 18, 2020. It is now read-only.
Index consistency check uses better checkpoints #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avieth
force-pushed
the
avieth/index_checkpoints
branch
2 times, most recently
from
856f344 to
5cdad07
Compare
avieth
force-pushed
the
avieth/index_checkpoints
branch
from
5cdad07 to
63b8f0c
Compare
Now the index will not always rollback to origin when its tip is not in the database. It will try to find an intersection point within the security parameter, and roll back only to that point.
avieth
force-pushed
the
avieth/index_checkpoints
branch
from
63b8f0c to
772e701
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the proxy starts up, it will check consistency between the index and database. It's possible that part of the index is not in the main database, whether because the database was updated in some out-of-band way, or because the proxy was shut down after the database forked but before the index was able to respond and synchronize.
Previously the index would be completely rebuild whenever its tip was not in the database. Now, it will use fibonacci checkpoints up to the security parameter k, just like for Shelley ChainSync and Byron chain download. If none of these at most k index entries have corresponding blocks in the database, then the whole thing will be rebuilt.
This includes #27. Should not be reviewed/merged until after that one.