Skip to content

redundant dependencies npm, i #1619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 of 4 tasks
ahmadi-akbar opened this issue May 5, 2025 · 2 comments · Fixed by #1620
Closed
2 of 4 tasks

redundant dependencies npm, i #1619

ahmadi-akbar opened this issue May 5, 2025 · 2 comments · Fixed by #1620
Labels
bug Something isn't working

Comments

@ahmadi-akbar
Copy link

Summary

i think we have added npm, i packages to @cardano-sdk/crypto accidental thus we have not use those packages
check this file
https://github.com/input-output-hk/cardano-js-sdk/blob/master/packages/crypto/package.json#L75
can you confirm and remove these packages?

Steps to reproduce the bug

No response

Actual Result

nothing

Expected Result

nothing

SDK version

0.2.3

Environment type

  • Node.js
  • Browser
  • Browser Extension
  • Other

Environment details

No response
@ahmadi-akbar ahmadi-akbar added the bug Something isn't working label May 5, 2025
@rhyslbw
Copy link
Member

rhyslbw commented May 5, 2025

Good catch! Feel free to open. PR to fix this

@ahmadi-akbar ahmadi-akbar mentioned this issue May 5, 2025
Merged
@ahmadi-akbar
Copy link
Author

ahmadi-akbar commented May 5, 2025 •
edited
Loading

@rhyslbw PR is ready to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove redundant npm, i packages ahmadi-akbar/cardano-js-sdk
2 participants
@rhyslbw @ahmadi-akbar