Skip to content
This repository was archived by the owner on Aug 1, 2023. It is now read-only.

[GH-170] Fix CI Hydra issue #171

Merged
merged 4 commits into from
May 29, 2019
Merged

[GH-170] Fix CI Hydra issue #171

merged 4 commits into from
May 29, 2019

Conversation

ksaric
Copy link
Contributor

@ksaric ksaric commented May 29, 2019

#170

Fix the failing CI and remove unnecessary Nix derivations.

@ksaric ksaric requested review from jbgi and HirotoShioi May 29, 2019 08:35
@ksaric ksaric requested a review from erikd as a code owner May 29, 2019 08:35
@ksaric
Copy link
Contributor Author

ksaric commented May 29, 2019

It would be nice if somebody reviewed #167 so we can merge that, rebase this and then merge this to fix all CI issues popping up:

@365andreas 365andreas self-requested a review May 29, 2019 08:43
@jbgi
Copy link
Contributor

jbgi commented May 29, 2019

runCoveralls is not needed anymore? (can be removed from default.nix then?)

@ksaric
Copy link
Contributor Author

ksaric commented May 29, 2019

@jbgi Good point, I'll put that back.

@ksaric
Copy link
Contributor Author

ksaric commented May 29, 2019

Added ci/hydra:Cardano:cardano-shell:required branch protection. Thanks @jbgi.

@ksaric
Copy link
Contributor Author

ksaric commented May 29, 2019

Why isn't Coveralls working? 🤔
Do we need to add it to the CI pipeline? And if so, won't that void the Hydra caches when building it?

Otherwise, I have no clue why it's not working.

@HirotoShioi
Copy link
Contributor

I've managed to run the test locally so if coveralls are fixed, LGTM

@ksaric
Copy link
Contributor Author

ksaric commented May 29, 2019

We can leave the coveralls issue for another task, not urgent.

@ksaric ksaric merged commit 872b100 into develop May 29, 2019
@ksaric ksaric deleted the ksaric/GH-170 branch May 29, 2019 09:55
This was referenced May 29, 2019
@365andreas
Copy link
Contributor

@ksaric Seems that 30829cc#diff-8b496edab86012a437e80897eb7129c0 removed coverage checking.

@ksaric
Copy link
Contributor Author

ksaric commented May 29, 2019

@365andreas Yep, I noticed that. Adding it here results in:

building '/nix/store/s3lka8z0wrivjvrvdzqb2x9a44lgim0d-stack-hpc-coveralls-0.0.4.0.drv'...
setupCompilerEnvironmentPhase
Build with /nix/store/61jvs7n897lrnb2d60mpl84js8jwi7if-ghc-8.4.3.
ignoring (possibly broken) abi-depends field for packages
unpacking sources
unpacking source archive /nix/store/7b3im8mq46vjdfy44lpimll7smhj4gfl-stack-hpc-coveralls-0.0.4.0.tar.gz
source root is stack-hpc-coveralls-0.0.4.0
setting SOURCE_DATE_EPOCH to timestamp 1465994082 of file stack-hpc-coveralls-0.0.4.0/stack.yaml
patching sources
compileBuildDriverPhase
setupCompileFlags: -package-db=/build/setup-package.conf.d -j12 -threaded
[1 of 1] Compiling Main             ( Setup.hs, /build/Main.o )
Linking Setup ...
configuring
configureFlags: --verbose --prefix=/nix/store/6mfjg609dql1kvzsp68m72y8pg93wgp0-stack-hpc-coveralls-0.0.4.0 --libdir=$prefix/lib/$compiler --libsubdir=$abi/$libname --docdir=/nix/store/79bk76ifsrcdzndfraqak4j28r90zxsi-stack-hpc-coveralls-0.0.4.0-doc/share/doc/stack-hpc-coveralls-0.0.4.0 --with-gcc=gcc --package-db=/build/package.conf.d --ghc-option=-j12 --disable-split-objs --enable-library-profiling --profiling-detail=exported-functions --disable-profiling --enable-shared --disable-coverage --enable-static --disable-executable-dynamic --enable-tests --enable-library-vanilla --enable-library-for-ghci --ghc-option=-split-sections --extra-lib-dirs=/nix/store/1nmw74s77li7qswbmbln0c74gln13i6w-ncurses-6.1/lib --extra-lib-dirs=/nix/store/kn55ah0qwa4gyr5nncjdagrwbq9s4n2p-gmp-6.1.2/lib
Using Parsec parser
Configuring stack-hpc-coveralls-0.0.4.0...
CallStack (from HasCallStack):
  die', called at libraries/Cabal/Cabal/Distribution/Simple/Configure.hs:958:20 in Cabal-2.2.0.1:Distribution.Simple.Configure
  configureFinalizedPackage, called at libraries/Cabal/Cabal/Distribution/Simple/Configure.hs:462:12 in Cabal-2.2.0.1:Distribution.Simple.Configure
  configure, called at libraries/Cabal/Cabal/Distribution/Simple.hs:609:20 in Cabal-2.2.0.1:Distribution.Simple
  confHook, called at libraries/Cabal/Cabal/Distribution/Simple/UserHooks.hs:67:5 in Cabal-2.2.0.1:Distribution.Simple.UserHooks
  configureAction, called at libraries/Cabal/Cabal/Distribution/Simple.hs:191:19 in Cabal-2.2.0.1:Distribution.Simple
  defaultMainHelper, called at libraries/Cabal/Cabal/Distribution/Simple.hs:119:27 in Cabal-2.2.0.1:Distribution.Simple
  defaultMain, called at Setup.hs:2:8 in main:Main
Setup: Encountered missing dependencies:
hlint ==1.*

builder for '/nix/store/s3lka8z0wrivjvrvdzqb2x9a44lgim0d-stack-hpc-coveralls-0.0.4.0.drv' failed with exit code 1
error: build of '/nix/store/s3lka8z0wrivjvrvdzqb2x9a44lgim0d-stack-hpc-coveralls-0.0.4.0.drv' failed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants