Update build to use nix-tools. #83

jbgi · 2019-04-03T15:04:38Z

nix-shell is not functional yet.

jbgi · 2019-04-03T15:36:43Z

Apparently there is some dependencies on unix that need to be guarded by an OS conditional in the cabal config, for cross-compilation to work.

CodiePP · 2019-04-03T16:02:12Z

@Jimbo4350 also did some work on this: https://github.com/input-output-hk/cardano-shell/tree/jordan/nix-build-unix-windows

CodiePP

everything green!
the build commands work, except the cross-compilation

CodiePP · 2019-04-05T07:08:09Z

bors try

ksaric · 2019-04-05T07:36:23Z

bors try harder

CodiePP · 2019-04-05T09:34:00Z

please, bors try

CodiePP · 2019-04-05T17:03:16Z

buildkite now failing..

CodiePP · 2019-05-10T06:04:09Z

rebased, regenerated nix files, update iohk-nix, and force pushed!
the cross-compilation is segfaulting (@angerman help!)
the command I used:
nix build -f release.nix nix-tools.libs.x86_64-pc-mingw32-cardano-shell.x86_64-linux

angerman · 2019-05-10T06:53:05Z

are you sure it's just cross that doesn't work @CodiePP?

Hydra paints a pretty bleak picture: https://hydra.iohk.io/jobset/Cardano/cardano-shell-pr-83#tabs-jobs

angerman · 2019-05-10T06:53:59Z

Ahh ... lovely:

ghc: could not execute: /nix/store/47awn0vmnkffgzrhabhp8ylbxm3c1b59-ghc-8.6.3-with-contra-tracer/lib/ghc-8.6.3/bin/unlit

🤔

angerman · 2019-05-10T06:55:49Z

I knew this sounded vaguely familiar: input-output-hk/haskell.nix#78

Guess I'll have to look into this now.

CodiePP

cross-compilation now successful
nix build -f release.nix nix-tools.libs.x86_64-pc-mingw32-cardano-shell.x86_64-linux

ksaric · 2019-05-13T12:55:21Z

The build doesn't work for me:

> stack build --nix -j12

trace: 
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
************************************ WARNING ***********************************
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

         You are using GHC 8.6.3.  This version is known to
         be busted on windows!  See GHC issue #16057.  Make
         sure you revert commit
           ghc:ed86e3b531322f74d2c2d00d7ff8662b08fabde6
         before using GHC 8.6.3 in any form on windows.

         --
         https://ghc.haskell.org/trac/ghc/ticket/16057

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
************************************ WARNING ***********************************
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

canonical-json-0.5.0.2: unregistering (local file changes: /home/ksaric/.stack/programs/x86_64-linux/ghc-8.6.3/lib/ghc-8.6.3/include/ghcversion.h /usr/inclu...)
canonical-json-0.5.0.2: build (lib)
profunctors-5.3: configure
canonical-json-0.5.0.2: copy/register
profunctors-5.3: build                                                     
semigroupoids-5.3.2: configure                                             
semigroupoids-5.3.2: build                                                 
threepenny-gui-0.8.3.0: configure                                          
threepenny-gui-0.8.3.0: build                                              
profunctors-5.3: copy/register                                             
semigroupoids-5.3.2: copy/register                 
Progress 4/21                     

--  While building package threepenny-gui-0.8.3.0 using:
      /home/ksaric/.stack/setup-exe-cache/x86_64-linux/Cabal-simple_mPHDZzAJ_2.4.0.1_ghc-8.6.3 --builddir=.stack-work/dist/x86_64-linux/Cabal-2.4.0.1 build --ghc-options " -ddump-hi -ddump-to-file -fdiagnostics-color=always"
    Process exited with code: ExitFailure 1
    Logs have been written to: /home/ksaric/projects/haskell/cardano-shell/.stack-work/logs/threepenny-gui-0.8.3.0.log

    Configuring threepenny-gui-0.8.3.0...
    Preprocessing library for threepenny-gui-0.8.3.0..
    Building library for threepenny-gui-0.8.3.0..
    [ 1 of 29] Compiling Foreign.JavaScript.Include ( src/Foreign/JavaScript/Include.hs, .stack-work/dist/x86_64-linux/Cabal-2.4.0.1/build/Foreign/JavaScript/Include.o )
    [ 2 of 29] Compiling Foreign.JavaScript.Resources ( src/Foreign/JavaScript/Resources.hs, .stack-work/dist/x86_64-linux/Cabal-2.4.0.1/build/Foreign/JavaScript/Resources.o )
    <command line>: can't load .so/.DLL for: libz.so (libz.so: cannot open shared object file: No such file or directory)

ruhatch · 2019-05-13T13:12:33Z

@ksaric how are you building it? You need the zlib dependency from somewhere.

ksaric · 2019-05-13T13:14:02Z

It's on the first line of the comment above, using stack.
Heh, from somewhere... I wish I knew where that is.

ksaric · 2019-05-13T13:19:37Z

@CodiePP The "pure" Nix build is working using nix build -f release.nix nix-tools.libs.x86_64-pc-mingw32-cardano-shell.x86_64-linux.

ruhatch · 2019-05-13T13:25:17Z

Ah, yes, good point - you can use something like the stack-shell.nix

ruhatch · 2019-05-13T13:25:55Z

Then in stack.yaml

nix:
  shell-file: path/to/stack-shell.nix

ruhatch · 2019-05-13T13:41:38Z

Oh, looks like you have that already, but it's different from ours and maybe doesn't have external dependencies

Signed-off-by: Alexander Diemand <[email protected]>

jbgi · 2019-05-21T12:47:57Z

@CodiePP stack build is fixed now. But it is not completely satisfactory because the nix-shell still depends on the cardano-shell lib components instead of only its dependencies (this will be fixed via input-output-hk/haskell.nix#121).

ksaric · 2019-05-21T12:51:50Z

@jbgi When running stack (stack build --fast --nix) I get:

Cloning cbe7ab32354f3838dc8c95c64109904c8f503347 from https://github.com/input-output-hk/iohk-monitoring-framework
Executable named git not found on path

To allow stack to pick git for user environnement. (waiting for input-output-hk/haskell.nix#121 for a better fix.

jbgi · 2019-05-21T13:01:07Z

@ksaric thanks, I missed that due to not trying from a fresh checkout.
While waiting for input-output-hk/haskell.nix#121 I have disabled purity for the nix-shell used by stack so that stack can pick-up git for the user environment.

CodiePP

👍 nix build -f release.nix nix-tools.libs.x86_64-pc-mingw32-cardano-shell.x86_64-linux works! 🆗
👍 stack build --nix works! 🆗

💯

jbgi · 2019-05-21T15:33:09Z

bors r+

ksaric

Stack builds, but we are waiting for #83 (comment) to be able to enable pure stack builds, right?
Otherwise LGTM, it builds 🎉

stack.yaml

jbgi added the wip Work In Progress label Apr 3, 2019

jbgi requested review from erikd and ksaric as code owners April 3, 2019 15:04

jbgi requested a review from CodiePP April 3, 2019 15:04

CodiePP approved these changes Apr 4, 2019

View reviewed changes

jbgi removed the wip Work In Progress label Apr 5, 2019

CodiePP self-requested a review April 5, 2019 19:44

jbgi force-pushed the nix-tools-update branch from b4595f5 to 69ce358 Compare April 8, 2019 09:20

CodiePP force-pushed the nix-tools-update branch from a0d0f37 to 8fc511f Compare May 10, 2019 06:03

CodiePP added the wip Work In Progress label May 10, 2019

CodiePP removed the wip Work In Progress label May 13, 2019

CodiePP approved these changes May 13, 2019

View reviewed changes

CodiePP force-pushed the nix-tools-update branch from 7e29e02 to 0767d79 Compare May 13, 2019 12:21

jbgi and others added 16 commits May 21, 2019 09:52

Clean-up unused nix files.

1a2dbeb

Bump process and transformers for compat with ghc 8.6

23af824

regenerated nix files; updated iohk-nix

aa87472

Signed-off-by: Alexander Diemand <[email protected]>

pinned logging to new version

8694bd4

Signed-off-by: Alexander Diemand <[email protected]>

Update pkgs.nix

4914ceb

Update pkgs.nix

a574b7f

Update pkgs.nix

0e4f409

allow: cabal new-build

ecc41a4

Signed-off-by: Alexander Diemand <[email protected]>

Update pkgs.nix

91b7cce

bump iohk-nix (and thus haskell.nix)

e8a41c2

regenerate

d5dd258

Fix katip on Windows

0696dba

Set doExactConfig on turtle on windows as well.

7ef88d8

trying cross-compilation

54eb075

Signed-off-by: Alexander Diemand <[email protected]>

rebased; stack2nix applied

6b25ec7

Signed-off-by: Alexander Diemand <[email protected]>

adapted; but still does not build with 'stack build --nix'

b291449

Signed-off-by: Alexander Diemand <[email protected]>

jbgi force-pushed the nix-tools-update branch from 060c1fd to bc0a344 Compare May 21, 2019 10:04

Update iohk-nix. Fix nix-shells.

f7be633

jbgi force-pushed the nix-tools-update branch from bc0a344 to f7be633 Compare May 21, 2019 12:20

jbgi requested a review from CodiePP May 21, 2019 12:44

Disable nix-shell purity in stack.yaml

6adf7c2

To allow stack to pick git for user environnement. (waiting for input-output-hk/haskell.nix#121 for a better fix.

CodiePP approved these changes May 21, 2019

View reviewed changes

ksaric approved these changes May 21, 2019

View reviewed changes

stack.yaml Show resolved Hide resolved

CodiePP merged commit 30829cc into develop May 21, 2019

jbgi mentioned this pull request May 31, 2019

Use new shellFor function to provide build env. #174

Merged

ksaric deleted the nix-tools-update branch June 5, 2019 09:22

Update build to use nix-tools. #83

Update build to use nix-tools. #83

Uh oh!

Conversation

jbgi commented Apr 3, 2019

Uh oh!

jbgi commented Apr 3, 2019

Uh oh!

CodiePP commented Apr 3, 2019

Uh oh!

CodiePP left a comment

Choose a reason for hiding this comment

Uh oh!

CodiePP commented Apr 5, 2019

Uh oh!

ksaric commented Apr 5, 2019

Uh oh!

CodiePP commented Apr 5, 2019

Uh oh!

CodiePP commented Apr 5, 2019

Uh oh!

CodiePP commented May 10, 2019

Uh oh!

angerman commented May 10, 2019

Uh oh!

angerman commented May 10, 2019

Uh oh!

angerman commented May 10, 2019

Uh oh!

CodiePP left a comment

Choose a reason for hiding this comment

Uh oh!

ksaric commented May 13, 2019

Uh oh!

ruhatch commented May 13, 2019

Uh oh!

ksaric commented May 13, 2019

Uh oh!

ksaric commented May 13, 2019

Uh oh!

ruhatch commented May 13, 2019

Uh oh!

ruhatch commented May 13, 2019

Uh oh!

ruhatch commented May 13, 2019

Uh oh!

jbgi commented May 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ksaric commented May 21, 2019

Uh oh!

jbgi commented May 21, 2019

Uh oh!

CodiePP left a comment

Choose a reason for hiding this comment

Uh oh!

jbgi commented May 21, 2019

Uh oh!

ksaric left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jbgi commented May 21, 2019 •

edited

Loading