Skip to content

Adds ghcjs and Asterius as cross compilers #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 16, 2019
Merged

Adds ghcjs and Asterius as cross compilers #106

merged 6 commits into from
May 16, 2019

Conversation

hamishmack
Copy link
Collaborator

No description provided.

@hamishmack hamishmack changed the title PoC for running ghcjs as a cross compiler WIP - PoC for running ghcjs as a cross compiler Apr 5, 2019
angerman
angerman requested changes Apr 5, 2019
View reviewed changes
@angerman angerman mentioned this pull request Apr 5, 2019
Merged
angerman
angerman requested changes Apr 5, 2019
View reviewed changes
@angerman
Copy link
Collaborator

angerman commented Apr 5, 2019

One issue, which @hamishmack was also raising is that this will break with stock nixpkgs.

error: attribute 'isGhcjs' missing, at /Users/travis/build/input-output-hk/haskell.nix/builder/comp-builder.nix:160:26
(use '--show-trace' to show detailed location information)
The command "NIX_PATH=nixpkgs=https://github.com/NixOS/nixpkgs-channels/archive/${CHANNEL}.tar.gz NIX_BUILD_ARGS="--cores 0 --max-jobs 2" ./test/tests.sh" exited with 1.

maybe we should provide some fallback for isGhcjs, if it's not defined?

@angerman angerman changed the title WIP - PoC for running ghcjs as a cross compiler Adds ghcjs as Asterius as cross compilers Apr 6, 2019
@angerman angerman changed the title Adds ghcjs as Asterius as cross compilers Adds ghcjs and Asterius as cross compilers May 6, 2019
@eamsden
Copy link
Contributor

eamsden commented May 8, 2019

@angerman @hamishmack is there a patched nixpkgs that exports system examples to be passed for GHCJS/Asterius compilation?

@angerman
Copy link
Collaborator

angerman commented May 9, 2019

@angerman @hamishmack is there a patched nixpkgs that exports system examples to be passed for GHCJS/Asterius compilation?

Not yet. But WIP.

angerman
angerman approved these changes May 16, 2019
View reviewed changes
Copy link
Collaborator

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angerman angerman merged commit 0cc3670 into input-output-hk:master May 16, 2019
andreabedini pushed a commit to andreabedini/haskell.nix that referenced this pull request Sep 14, 2022
@puffnfresh
Fix source-repo under Cabal 3.4 generated plans (input-output-hk#106)
5af6d11 
They are no longer always local:

haskell/cabal@2b6cd51

haskell/cabal#5586
andreabedini pushed a commit to andreabedini/haskell.nix that referenced this pull request Sep 14, 2022
@puffnfresh
Fix source-repo under Cabal 3.4 generated plans (input-output-hk#106)
a640086 
They are no longer always local:

haskell/cabal@2b6cd51

haskell/cabal#5586
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angerman angerman angerman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hamishmack @angerman @eamsden