-
Notifications
You must be signed in to change notification settings - Fork 247
Add shellHook option to components (and packages and plans) #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shellHook option to components (and packages and plans) #117
Conversation
@eamsden so wait, we already had a |
No, the component builder took an optional shellHook input, but it wasn't passed anywhere. I just added a shellHook option to the list of options that gets replicated at the plan, package, and component levels, and pushed down. Then I made component-builder.nix pass the component shellHook config to the builder as an argument. So now you can configure shellHook at any level in the same way as (say) setupBuildFlags. |
I've tested this and gotten working shellHooks. I think it is ready for you to look at @angerman |
@@ -73,6 +73,11 @@ let | |||
type = bool; | |||
default = (def.doHaddock or true); | |||
}; | |||
shellHook = mkOption { | |||
description = "Hook to run when entering a shell"; | |||
type = unspecified; # Can be either a string or a function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we could craft a custom type. But for now this is porbably good enough.
* Fix union version ranges * Fixes for latest aeson
* Fix union version ranges * Fixes for latest aeson
I am going to test this soon but my build machines are consumed by cross-compiling. This adds a way to specify shellHooks at plan, package, and component levels, in answer to #114