Run the nightly scripts to also update the index-state-hashes #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the index-state-hashes to `hackage.nix` as well. Thus we need to have a least one hackage.nix update in.
|
It looks like it will work! I find the bash script in |
I've added quite a bit of comments. I hope that makes the script easier to understand. I like that we have almost zero dependencies for bash usage. I'm not sure a haskell script would be much more readable either :( |
Closed
michaelpj
reviewed
Jun 21, 2019
| @@ -20,6 +20,10 @@ import ./update-external.nix args { | |||
|
|
|||
| hackage-to-nix hackage.nix | |||
|
|
|||
| echo "Running update-index-state-hashes..." | |||
|
|
|||
| ${update-index-state-hashes}/bin/update-index-state-hashes > ./index-state-hashes.nix | |||
There was a problem hiding this comment.
Should this be called after cd-ing into hackage.nix? As it is it looks like it won't modify the copy in hackage.nix. And indeed the file hasn't been modified in hackage.nix in some time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the index-state-hashes to
hackage.nixas well. Thuswe need to have a least one hackage.nix update in.