Skip to content

Add snapshots attribute #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 27, 2019
Merged

Add snapshots attribute #151

merged 4 commits into from
May 27, 2019

Conversation

rvl
Copy link
Contributor

@rvl rvl commented May 27, 2019

This provides stackage LTS package sets that you can just use without needing mkStackPkgSet.

This will be useful together with ghcWithPackages and ghcWithHoogle (PR #150).

rvl added 2 commits May 27, 2019 10:10
These contain package sets for all of the Stackage snapshots.

Relates to #22
@rvl rvl added the enhancement New feature or request label May 27, 2019
@rvl rvl self-assigned this May 27, 2019
Copy link
Collaborator

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this will give us bare lts snapshots? Wouldn't we want to allow to add a set of packages to them?

I'm thinking someone might want lts-X.Y + [ pkg-A.B.C.D ... ]?

@rvl
Copy link
Contributor Author

rvl commented May 27, 2019

The idea is that you could use these snapshots more or less like haskellPackages in nixpkgs.

Wouldn't we want to allow to add a set of packages to them?

You would need to use mkStackPkgSet for this. Haskell.nix offers no way of extending a package set after it's been created.

@angerman
Copy link
Collaborator

I was wondering if we could make

haskellPackages = self.snapshots."lts-13.18";

take a parameter, and then just inject the packages. But That would bring in all kinds of nasty dependency solving issues.

@angerman
Copy link
Collaborator

@rvl, I think we should merge this if with the added comment as per the review above.

@angerman angerman merged commit 37a1b7a into master May 27, 2019
@rvl rvl deleted the rvl/lts-haskell branch May 27, 2019 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants